Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 660653006: Use scoped_ptr::Pass instead of scoped_ptr::PassAs<T>. (Closed)

Created:
6 years, 2 months ago by dcheng
Modified:
6 years, 2 months ago
Reviewers:
tzik
CC:
chromium-reviews, kinuko+fileapi, nhiroki, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use scoped_ptr::Pass instead of scoped_ptr::PassAs<T>. BUG=423621 Committed: https://crrev.com/1f8f29add4c79ca10621a52067979cb8215783d0 Cr-Commit-Position: refs/heads/master@{#300040}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M storage/browser/fileapi/local_file_util.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M storage/browser/fileapi/native_file_util.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dcheng
6 years, 2 months ago (2014-10-16 21:54:10 UTC) #2
tzik
lgtm
6 years, 2 months ago (2014-10-17 00:45:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/660653006/1
6 years, 2 months ago (2014-10-17 00:49:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-17 01:53:25 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 01:54:12 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1f8f29add4c79ca10621a52067979cb8215783d0
Cr-Commit-Position: refs/heads/master@{#300040}

Powered by Google App Engine
This is Rietveld 408576698