chrome/browser/ui/cocoa/extensions/windowed_install_dialog_controller_browsertest.mm - Issue 660643002: [Refactor] Move creating a browser if necessary to ExtensionInstallDialogView

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/windowed_install_dialog_controller_browsertest.mm

Issue 660643002: [Refactor] Move creating a browser if necessary to ExtensionInstallDialogView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/extensions/windowed_install_dialog_controller.mm ('k') | chrome/browser/ui/extensions/extension_enable_flow.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/windowed_install_dialog_controller_browsertest.mm

diff --git a/chrome/browser/ui/cocoa/extensions/windowed_install_dialog_controller_browsertest.mm b/chrome/browser/ui/cocoa/extensions/windowed_install_dialog_controller_browsertest.mm

index 8c9ac58731f89e670f7b306d5deffca52608ed24..3987b93efe8f8cca82430761b4f98ce84fba5cb1 100644

--- a/chrome/browser/ui/cocoa/extensions/windowed_install_dialog_controller_browsertest.mm

+++ b/chrome/browser/ui/cocoa/extensions/windowed_install_dialog_controller_browsertest.mm

@@ -37,7 +37,7 @@ IN_PROC_BROWSER_TEST_F(WindowedInstallDialogControllerBrowserTest,

// Construct a prompt with a NULL parent window, the way ExtensionEnableFlow

// will for the Mac app list. For testing, sets a NULL PageNavigator as well.

scoped_ptr<ExtensionInstallPrompt> prompt(

- new ExtensionInstallPrompt(browser()->profile(), NULL, NULL));

+ new ExtensionInstallPrompt(browser()->profile(), NULL));

WindowedInstallDialogController* controller = NULL;

chrome::MockExtensionInstallPromptDelegate delegate;