chrome/browser/ui/views/extensions/extension_install_dialog_view_browsertest.cc - Issue 660643002: [Refactor] Move creating a browser if necessary to ExtensionInstallDialogView

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/extensions/extension_install_dialog_view_browsertest.cc

Issue 660643002: [Refactor] Move creating a browser if necessary to ExtensionInstallDialogView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/extensions/windowed_install_dialog_controller.mm ('K') | « chrome/browser/ui/views/extensions/extension_install_dialog_view.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/extensions/extension_install_dialog_view_browsertest.cc

diff --git a/chrome/browser/ui/views/extensions/extension_install_dialog_view_browsertest.cc b/chrome/browser/ui/views/extensions/extension_install_dialog_view_browsertest.cc

index c75101c050fb43f9657a83f21e3ed3ac603808f3..cecada130e307bf506651105d1124619a6704c3b 100644

--- a/chrome/browser/ui/views/extensions/extension_install_dialog_view_browsertest.cc

+++ b/chrome/browser/ui/views/extensions/extension_install_dialog_view_browsertest.cc

@@ -163,7 +163,10 @@ ScrollbarTest::ScrollbarTest()

bool ScrollbarTest::IsScrollbarVisible() {

ExtensionInstallPrompt::ShowParams show_params(web_contents());

ExtensionInstallDialogView* dialog = new ExtensionInstallDialogView(

- show_params.navigator, delegate(), prompt());

+ show_params.profile,

+ show_params.parent_web_contents,

+ delegate(),

+ prompt());

// Create the modal view around the install dialog view.

views::Widget* modal =

@@ -223,7 +226,8 @@ IN_PROC_BROWSER_TEST_F(ExtensionInstallDialogViewTest, NotifyDelegate) {

// The user confirms the install.

MockExtensionInstallPromptDelegate delegate;

scoped_ptr<ExtensionInstallDialogView> dialog(

- new ExtensionInstallDialogView(web_contents(), &delegate, prompt()));

+ new ExtensionInstallDialogView(

+ profile(), web_contents(), &delegate, prompt()));

views::DialogDelegateView* delegate_view = dialog.get();

delegate_view->Accept();

@@ -238,7 +242,8 @@ IN_PROC_BROWSER_TEST_F(ExtensionInstallDialogViewTest, NotifyDelegate) {

// The user cancels the install.

MockExtensionInstallPromptDelegate delegate;

scoped_ptr<ExtensionInstallDialogView> dialog(

- new ExtensionInstallDialogView(web_contents(), &delegate, prompt()));

+ new ExtensionInstallDialogView(

+ profile(), web_contents(), &delegate, prompt()));

views::DialogDelegateView* delegate_view = dialog.get();

delegate_view->Cancel();

@@ -254,7 +259,8 @@ IN_PROC_BROWSER_TEST_F(ExtensionInstallDialogViewTest, NotifyDelegate) {

// proceed or cancel.

MockExtensionInstallPromptDelegate delegate;

scoped_ptr<ExtensionInstallDialogView> dialog(

- new ExtensionInstallDialogView(web_contents(), &delegate, prompt()));

+ new ExtensionInstallDialogView(

+ profile(), web_contents(), &delegate, prompt()));

dialog.reset();

EXPECT_EQ(1, delegate.abort_count());