Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Unified Diff: chrome/browser/extensions/extension_install_prompt.cc

Issue 660643002: [Refactor] Move creating a browser if necessary to ExtensionInstallDialogView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_install_prompt.cc
diff --git a/chrome/browser/extensions/extension_install_prompt.cc b/chrome/browser/extensions/extension_install_prompt.cc
index 0af21940338ff4a6ee58dd25248b0c960ba20dba..0551cc1b74259e3511f7fbc99c272c5a2cb2bdbd 100644
--- a/chrome/browser/extensions/extension_install_prompt.cc
+++ b/chrome/browser/extensions/extension_install_prompt.cc
@@ -613,17 +613,16 @@ bool ExtensionInstallPrompt::Prompt::ShouldDisplayRevokeFilesButton() const {
}
ExtensionInstallPrompt::ShowParams::ShowParams(content::WebContents* contents)
- : parent_web_contents(contents),
- parent_window(NativeWindowForWebContents(contents)),
- navigator(contents) {
+ : profile(ProfileForWebContents(contents)),
+ parent_web_contents(contents),
+ parent_window(NativeWindowForWebContents(contents)) {
}
-ExtensionInstallPrompt::ShowParams::ShowParams(
- gfx::NativeWindow window,
- content::PageNavigator* navigator)
- : parent_web_contents(NULL),
- parent_window(window),
- navigator(navigator) {
+ExtensionInstallPrompt::ShowParams::ShowParams(Profile* profile,
+ gfx::NativeWindow window)
+ : profile(profile),
+ parent_web_contents(NULL),
+ parent_window(window) {
}
// static
@@ -666,15 +665,13 @@ ExtensionInstallPrompt::ExtensionInstallPrompt(content::WebContents* contents)
delegate_(NULL) {
}
-ExtensionInstallPrompt::ExtensionInstallPrompt(
- Profile* profile,
- gfx::NativeWindow native_window,
- content::PageNavigator* navigator)
+ExtensionInstallPrompt::ExtensionInstallPrompt(Profile* profile,
+ gfx::NativeWindow native_window)
: ui_loop_(base::MessageLoop::current()),
extension_(NULL),
bundle_(NULL),
install_ui_(ExtensionInstallUI::Create(profile)),
- show_params_(native_window, navigator),
+ show_params_(profile, native_window),
delegate_(NULL) {
}

Powered by Google App Engine
This is Rietveld 408576698