chrome/browser/apps/ephemeral_app_launcher.cc - Issue 660643002: [Refactor] Move creating a browser if necessary to ExtensionInstallDialogView

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/apps/ephemeral_app_launcher.cc

Issue 660643002: [Refactor] Move creating a browser if necessary to ExtensionInstallDialogView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/extensions/extension_install_prompt.h » ('j') | chrome/browser/ui/cocoa/extensions/windowed_install_dialog_controller.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/apps/ephemeral_app_launcher.cc

diff --git a/chrome/browser/apps/ephemeral_app_launcher.cc b/chrome/browser/apps/ephemeral_app_launcher.cc

index ae4b13b6e0092e5a71d9600f0535956d57aa802a..90f423f494643ebfe19f10c5eb30ebb782c91356 100644

--- a/chrome/browser/apps/ephemeral_app_launcher.cc

+++ b/chrome/browser/apps/ephemeral_app_launcher.cc

@@ -187,8 +187,7 @@ scoped_ptr<ExtensionInstallPrompt> EphemeralAppLauncher::CreateInstallUI() {

if (web_contents())

return make_scoped_ptr(new ExtensionInstallPrompt(web_contents()));

- return make_scoped_ptr(

- new ExtensionInstallPrompt(profile(), parent_window_, NULL));

+ return make_scoped_ptr(new ExtensionInstallPrompt(profile(), parent_window_));

}

scoped_ptr<WebstoreInstaller::Approval> EphemeralAppLauncher::CreateApproval()