content/browser/accessibility/browser_accessibility_win.cc - Issue 660633002: Fixed IAccessibleText::TextAtOffset with IA2_TEXT_BOUNDARY_WORD to return text that spans from the …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility_win.cc

Issue 660633002: Fixed IAccessibleText::TextAtOffset with IA2_TEXT_BOUNDARY_WORD to return text that spans from the … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added semi-automated NVDA test for word navigation and removed dependency on pywinauto. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/accessibility/browser_accessibility.cc ('K') | « content/browser/accessibility/browser_accessibility.cc ('k') | content/browser/accessibility/browser_accessibility_win_unittest.cc » ('j') | tools/accessibility/nvda/nvda_chrome_tests.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/browser_accessibility_win.cc

diff --git a/content/browser/accessibility/browser_accessibility_win.cc b/content/browser/accessibility/browser_accessibility_win.cc

index 72022d3cb7344bb72213fb8f7ea5a0c0f726569d..9999cbdb5f637905c44ab36efb38d1d88273bf25 100644

--- a/content/browser/accessibility/browser_accessibility_win.cc

+++ b/content/browser/accessibility/browser_accessibility_win.cc

@@ -3297,6 +3297,9 @@ LONG BrowserAccessibilityWin::FindBoundary(

IA2TextBoundaryType ia2_boundary,

LONG start_offset,

ui::TextBoundaryDirection direction) {

+ if (ia2_boundary == IA2_TEXT_BOUNDARY_WORD && IsEditableText())

dmazzoni 2014/11/03 16:26:49 The fact that you're calling IsEditableText() here

+ return GetWordStartBoundary(static_cast<int>(start_offset), direction);

HandleSpecialTextOffset(text, &start_offset);

dmazzoni 2014/11/03 16:26:49 I think you should do this call before GetWordStar

ui::TextBoundaryType boundary = IA2TextBoundaryToTextBoundary(ia2_boundary);

const std::vector<int32>& line_breaks = GetIntListAttribute(