Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(845)

Unified Diff: content/browser/accessibility/browser_accessibility.cc

Issue 660633002: Fixed IAccessibleText::TextAtOffset with IA2_TEXT_BOUNDARY_WORD to return text that spans from the … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Disabled mltiline unit test. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/accessibility/browser_accessibility.cc
diff --git a/content/browser/accessibility/browser_accessibility.cc b/content/browser/accessibility/browser_accessibility.cc
index b41a21b5bbe123d50b0d06df4ff574abedadbe43..7a8c56020e5dcd761f5b3378e801c046a8a272a0 100644
--- a/content/browser/accessibility/browser_accessibility.cc
+++ b/content/browser/accessibility/browser_accessibility.cc
@@ -4,12 +4,15 @@
#include "content/browser/accessibility/browser_accessibility.h"
+#include <algorithm>
+
#include "base/logging.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/string_util.h"
#include "base/strings/utf_string_conversions.h"
#include "content/browser/accessibility/browser_accessibility_manager.h"
#include "content/common/accessibility_messages.h"
+#include "ui/accessibility/ax_text_utils.h"
namespace content {
@@ -307,6 +310,75 @@ gfx::Rect BrowserAccessibility::GetGlobalBoundsForRange(int start, int len)
return bounds;
}
+int BrowserAccessibility::GetWordStartBoundary(
+ int start, ui::TextBoundaryDirection direction) const {
+ int word_start = 0;
+ int prev_word_start = 0;
+ if (GetRole() != ui::AX_ROLE_STATIC_TEXT) {
+ for (size_t i = 0; i < InternalChildCount(); ++i) {
+ BrowserAccessibility* child = InternalGetChild(i);
+ int child_len = child->GetStaticTextLenRecursive();
+ int child_word_start = child->GetWordStartBoundary(start, direction);
+ word_start += child_word_start;
+ if (child_word_start != child_len)
+ break;
+ start -= child_len;
+ }
+ return word_start;
+ }
+
+ int child_start = 0;
+ int child_end = 0;
+ for (size_t i = 0; i < InternalChildCount(); ++i) {
+ // The next child starts where the previous one ended.
+ child_start = child_end;
+ BrowserAccessibility* child = InternalGetChild(i);
+ DCHECK_EQ(child->GetRole(), ui::AX_ROLE_INLINE_TEXT_BOX);
+ const std::string& child_text = child->GetStringAttribute(
+ ui::AX_ATTR_VALUE);
+ int child_len = static_cast<int>(child_text.size());
+ child_end += child_len; // End is one past the last character.
+
+ const std::vector<int32>& word_starts = child->GetIntListAttribute(
+ ui::AX_ATTR_WORD_STARTS);
+ if (word_starts.empty()) {
+ word_start = child_end;
+ continue;
+ }
+
+ int local_start = start - child_start;
+ std::vector<int32>::const_iterator iter = std::upper_bound(
+ word_starts.begin(), word_starts.end(), local_start);
+ if (iter != word_starts.end()) {
+ if (direction == ui::FORWARDS_DIRECTION) {
+ word_start = child_start + *iter;
+ } else if (direction == ui::BACKWARDS_DIRECTION) {
+ if (iter == word_starts.begin()) {
+ // Return the position of the last word in the previous child.
+ word_start = prev_word_start;
+ } else {
+ word_start = child_start + *(iter - 1);
+ }
+ } else {
+ NOTREACHED();
+ }
+ break;
+ }
+
+ // No word start that is >= to the requested offset has been found.
+ prev_word_start = child_start + *(iter - 1);
+ if (direction == ui::FORWARDS_DIRECTION) {
+ word_start = child_end;
+ } else if (direction == ui::BACKWARDS_DIRECTION) {
+ word_start = prev_word_start;
+ } else {
+ NOTREACHED();
+ }
+ }
+
+ return word_start;
+}
+
BrowserAccessibility* BrowserAccessibility::BrowserAccessibilityForPoint(
const gfx::Point& point) {
// The best result found that's a child of this object.
« no previous file with comments | « content/browser/accessibility/browser_accessibility.h ('k') | content/browser/accessibility/browser_accessibility_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698