Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 660613002: Fix dependency list of components/user_manager GN (Closed)

Created:
6 years, 2 months ago by Jun Mukai
Modified:
6 years, 2 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix dependency list of components/user_manager GN BUG=None R=nkostylev@chromium.org TEST=manually Committed: https://crrev.com/6bd0638f54adb9a208d18ff578f9a95f5f4b838b Cr-Commit-Position: refs/heads/master@{#299937}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix #

Patch Set 3 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M components/user_manager/BUILD.gn View 1 2 2 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
Jun Mukai
6 years, 2 months ago (2014-10-15 18:59:12 UTC) #1
Nikita (slow)
lgtm https://codereview.chromium.org/660613002/diff/1/components/user_manager/BUILD.gn File components/user_manager/BUILD.gn (right): https://codereview.chromium.org/660613002/diff/1/components/user_manager/BUILD.gn#newcode18 components/user_manager/BUILD.gn:18: "//base/third_party/dynamic_annotations", not sure where this one is used.
6 years, 2 months ago (2014-10-16 05:21:57 UTC) #2
Jun Mukai
https://codereview.chromium.org/660613002/diff/1/components/user_manager/BUILD.gn File components/user_manager/BUILD.gn (right): https://codereview.chromium.org/660613002/diff/1/components/user_manager/BUILD.gn#newcode18 components/user_manager/BUILD.gn:18: "//base/third_party/dynamic_annotations", On 2014/10/16 05:21:56, Nikita Kostylev wrote: > not ...
6 years, 2 months ago (2014-10-16 17:24:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/660613002/20001
6 years, 2 months ago (2014-10-16 17:26:46 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/8477)
6 years, 2 months ago (2014-10-16 17:49:10 UTC) #7
Jun Mukai
Oops, I noticed several mistakes on GN file, and I think it's better to address ...
6 years, 2 months ago (2014-10-16 17:59:21 UTC) #8
Nikita (slow)
lgtm
6 years, 2 months ago (2014-10-16 18:05:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/660613002/40001
6 years, 2 months ago (2014-10-16 18:07:21 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 2 months ago (2014-10-16 18:30:03 UTC) #12
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 18:34:17 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6bd0638f54adb9a208d18ff578f9a95f5f4b838b
Cr-Commit-Position: refs/heads/master@{#299937}

Powered by Google App Engine
This is Rietveld 408576698