Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 660573007: Open HID connections asynchronously. (Closed)

Created:
6 years, 2 months ago by Reilly Grant (use Gerrit)
Modified:
6 years, 2 months ago
Reviewers:
rpaquay
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Open HID connections asynchronously. By making HidService::Connect return its result asynchronously platform specific details such as whether device nodes must be opened on a different thread (due to blocking) or requesting access from the Chrome OS permission broker can be abstracted away. BUG=422540 Committed: https://crrev.com/7f4f508547ac3058d7c47337313972ec1ac2fb1b Cr-Commit-Position: refs/heads/master@{#299950}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -120 lines) Patch
M device/hid/hid_connection_unittest.cc View 3 chunks +36 lines, -9 lines 0 comments Download
M device/hid/hid_service.h View 2 chunks +7 lines, -9 lines 0 comments Download
M device/hid/hid_service_linux.h View 2 chunks +6 lines, -11 lines 0 comments Download
M device/hid/hid_service_linux.cc View 3 chunks +78 lines, -51 lines 0 comments Download
M device/hid/hid_service_mac.h View 1 chunk +2 lines, -2 lines 0 comments Download
M device/hid/hid_service_mac.cc View 3 chunks +13 lines, -7 lines 0 comments Download
M device/hid/hid_service_win.h View 2 chunks +4 lines, -2 lines 0 comments Download
M device/hid/hid_service_win.cc View 3 chunks +19 lines, -8 lines 0 comments Download
M extensions/browser/api/hid/hid_api.h View 1 chunk +1 line, -2 lines 0 comments Download
M extensions/browser/api/hid/hid_api.cc View 1 chunk +9 lines, -19 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Reilly Grant (use Gerrit)
Please take a look.
6 years, 2 months ago (2014-10-15 23:52:17 UTC) #2
rpaquay
lgtm
6 years, 2 months ago (2014-10-16 18:03:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/660573007/1
6 years, 2 months ago (2014-10-16 18:07:25 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-16 19:19:32 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 19:22:30 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7f4f508547ac3058d7c47337313972ec1ac2fb1b
Cr-Commit-Position: refs/heads/master@{#299950}

Powered by Google App Engine
This is Rietveld 408576698