Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 660543002: Fix unhandled promise console message to show stack trace of a DOMException. (Closed)

Created:
6 years, 2 months ago by aandrey
Modified:
6 years, 2 months ago
Reviewers:
pfeldman, yurys
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, blink-reviews-bindings_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, arv+blink, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

Fix unhandled promise console message to show stack trace of a DOMException. BUG=393913 R=pfeldman@chromium.org, yurys@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183985

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -26 lines) Patch
A + LayoutTests/inspector/sources/debugger/debugger-uncaught-promise-on-dom-exception.html View 3 chunks +18 lines, -26 lines 0 comments Download
A LayoutTests/inspector/sources/debugger/debugger-uncaught-promise-on-dom-exception-expected.txt View 1 chunk +13 lines, -0 lines 0 comments Download
M Source/bindings/core/v8/V8Initializer.cpp View 1 chunk +11 lines, -0 lines 0 comments Download
M Source/bindings/core/v8/V8ThrowException.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
aandrey
This depends on https://codereview.chromium.org/655243002/
6 years, 2 months ago (2014-10-15 14:47:05 UTC) #1
aandrey
On 2014/10/15 14:47:05, aandrey wrote: > This depends on https://codereview.chromium.org/655243002/ ... and on https://codereview.chromium.org/657063002/
6 years, 2 months ago (2014-10-15 14:55:58 UTC) #2
yurys
lgtm
6 years, 2 months ago (2014-10-17 09:38:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/660543002/1
6 years, 2 months ago (2014-10-17 09:54:23 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/builds/13900) mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/27463)
6 years, 2 months ago (2014-10-17 10:05:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/660543002/1
6 years, 2 months ago (2014-10-20 13:08:10 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 14:29:39 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 183985

Powered by Google App Engine
This is Rietveld 408576698