tools/telemetry/telemetry/page/page_set.py - Issue 660523004: Refactor _IsValidPrivacyBucket.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/page_set.py

Issue 660523004: Refactor _IsValidPrivacyBucket. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/telemetry/telemetry/page/page_set.py

diff --git a/tools/telemetry/telemetry/page/page_set.py b/tools/telemetry/telemetry/page/page_set.py

index ce4a67549ba47c320708039b4b9dbd1192b355a7..eb72c3a78bd2e1f61308265d6a8af542d862fe7d 100644

--- a/tools/telemetry/telemetry/page/page_set.py

+++ b/tools/telemetry/telemetry/page/page_set.py

@@ -75,11 +75,7 @@ class PageSet(user_story_set.UserStorySet):

@staticmethod

def _IsValidPrivacyBucket(bucket_name):

- if not bucket_name:

- return True

- if (bucket_name in [PUBLIC_BUCKET, PARTNER_BUCKET, INTERNAL_BUCKET]):

- return True

- return False

+ return bucket_name in (None, PUBLIC_BUCKET, PARTNER_BUCKET, INTERNAL_BUCKET)

@property

def base_dir(self):

« no previous file with comments | « no previous file | no next file » | no next file with comments »