Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 660523003: Simplify BackgroundImageGeometry by removing meaningless distinctions. (Closed)

Created:
6 years, 2 months ago by jbroman
Modified:
6 years, 2 months ago
Reviewers:
pdr., f(malita), chrishtr, eae
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Simplify BackgroundImageGeometry by removing meaningless distinctions. m_destOrigin is only set at the very end of BoxPainter::calculateBackgroundImageGeometry, and then always to destRect().location(). m_destRect is not changed after this point. m_destOrigin is only read in relativePhase(), which is only called after the end of calculateBackgroundGeometry. As a result, relativePhase() always returns m_phase, and we should be able to safely remove both relativePhase and destOrigin. It's not entirely clear to me what these were supposed to do, but at the moment they do nothing. TEST=LayoutTests Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183771

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -19 lines) Patch
M Source/core/paint/BackgroundImageGeometry.h View 2 chunks +0 lines, -10 lines 0 comments Download
M Source/core/paint/BackgroundImageGeometry.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M Source/core/paint/BoxPainter.cpp View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jbroman
6 years, 2 months ago (2014-10-15 19:31:24 UTC) #2
jbroman
I couldn't find any distinction here while trying to understand this code, and the layout ...
6 years, 2 months ago (2014-10-15 19:32:19 UTC) #4
pdr.
LGTM
6 years, 2 months ago (2014-10-15 22:50:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/660523003/1
6 years, 2 months ago (2014-10-15 22:50:44 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-15 22:54:49 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 183771

Powered by Google App Engine
This is Rietveld 408576698