Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 660523002: DevTools: add support for chunked protocol messages. (Closed)

Created:
6 years, 2 months ago by pfeldman
Modified:
6 years, 2 months ago
Reviewers:
dgozman, alph
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: add support for chunked protocol messages. BUG=423738 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183753

Patch Set 1 #

Patch Set 2 : #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -1 line) Patch
M Source/devtools/front_end/host/InspectorFrontendHost.js View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/devtools/front_end/sdk/InspectorBackend.js View 1 2 chunks +21 lines, -1 line 6 comments Download

Messages

Total messages: 8 (2 generated)
pfeldman
6 years, 2 months ago (2014-10-15 13:31:29 UTC) #2
alph
lgtm https://codereview.chromium.org/660523002/diff/20001/Source/devtools/front_end/sdk/InspectorBackend.js File Source/devtools/front_end/sdk/InspectorBackend.js (right): https://codereview.chromium.org/660523002/diff/20001/Source/devtools/front_end/sdk/InspectorBackend.js#newcode642 Source/devtools/front_end/sdk/InspectorBackend.js:642: var messageSize = /** @type {number} */ (event.data["messageSize"]); ...
6 years, 2 months ago (2014-10-15 13:44:58 UTC) #3
dgozman
https://codereview.chromium.org/660523002/diff/20001/Source/devtools/front_end/sdk/InspectorBackend.js File Source/devtools/front_end/sdk/InspectorBackend.js (right): https://codereview.chromium.org/660523002/diff/20001/Source/devtools/front_end/sdk/InspectorBackend.js#newcode633 Source/devtools/front_end/sdk/InspectorBackend.js:633: this.dispatch(/** @type {string} */ (event.data)); event.data could actually be ...
6 years, 2 months ago (2014-10-15 13:51:39 UTC) #4
pfeldman
https://codereview.chromium.org/660523002/diff/20001/Source/devtools/front_end/sdk/InspectorBackend.js File Source/devtools/front_end/sdk/InspectorBackend.js (right): https://codereview.chromium.org/660523002/diff/20001/Source/devtools/front_end/sdk/InspectorBackend.js#newcode633 Source/devtools/front_end/sdk/InspectorBackend.js:633: this.dispatch(/** @type {string} */ (event.data)); Which layout tests? https://codereview.chromium.org/660523002/diff/20001/Source/devtools/front_end/sdk/InspectorBackend.js#newcode642 ...
6 years, 2 months ago (2014-10-15 14:06:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/660523002/20001
6 years, 2 months ago (2014-10-15 14:07:20 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-15 15:10:43 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as 183753

Powered by Google App Engine
This is Rietveld 408576698