Issue 660503002: Revert of [DevTools] Inject element into toolbox window, do not load modules there.

Issue 660503002: Revert of [DevTools] Inject element into toolbox window, do not load modules there. (Closed)

Created:
6 years, 2 months ago by dgozman

Modified:
6 years, 2 months ago

Reviewers:
pfeldman

CC:
blink-reviews, vsevik+blink_chromium.org, caseq+blink_chromium.org, arv+blink, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, loislo+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, blink-reviews-bindings_chromium.org, Inactive, devtools-reviews_chromium.org, apavlov+blink_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Revert of [DevTools] Inject element into toolbox window, do not load modules there. (patchset #2 id:150001 of https://codereview.chromium.org/653613002/) Reason for revert: Breaks all references to "document". Original issue's description: > [DevTools] Inject element into toolbox window, do not load modules there. > > BUG=none > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183669 TBR=pfeldman@chromium.org NOTREECHECKS=true NOTRY=true BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183744

Patch Set 1 #

Created: 6 years, 2 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+56 lines, -60 lines)			Patch
M	Source/bindings/core/v8/custom/V8InspectorFrontendHostCustom.cpp	View	2 chunks	+6 lines, -12 lines	0 comments	Download
M	Source/core/inspector/InspectorFrontendHost.idl	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/devtools/front_end/host/InspectorFrontendHost.js	View	3 chunks	+4 lines, -10 lines	0 comments	Download
M	Source/devtools/front_end/main/AdvancedApp.js	View	1 chunk	+7 lines, -17 lines	0 comments	Download
M	Source/devtools/front_end/toolbox.json	View	2 chunks	+16 lines, -0 lines	0 comments	Download
M	Source/devtools/front_end/toolbox/MediaQueryInspector.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/devtools/front_end/toolbox/ToolboxDelegate.js	View	1 chunk	+3 lines, -7 lines	0 comments	Download
M	Source/devtools/front_end/toolbox_bootstrap/Toolbox.js	View	1 chunk	+14 lines, -4 lines	0 comments	Download
M	Source/devtools/front_end/toolbox_bootstrap/module.json	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	Source/devtools/front_end/ui/ContextMenu.js	View	3 chunks	+3 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

dgozman

Created Revert of [DevTools] Inject element into toolbox window, do not load modules there.

6 years, 2 months ago (2014-10-15 12:57:14 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/660503002/1

6 years, 2 months ago (2014-10-15 12:58:12 UTC) #2

commit-bot: I haz the power

6 years, 2 months ago (2014-10-15 12:58:58 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 183744

Expand Messages | Collapse Messages