Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 660473003: Content Shell: Typo in header. (Closed)

Created:
6 years, 2 months ago by Mike West
Modified:
6 years, 2 months ago
Reviewers:
marja
CC:
chromium-reviews, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jam, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git/+/master
Project:
chromium
Visibility:
Public.

Description

Content Shell: Typo in header. Oooh. I am stupid, and I have no idea how this compiled. :) BUG=420994 TBR=marja@chromium.org Committed: https://crrev.com/b49778b1f891e8d0ad5368041c1b8559be110d26 Cr-Commit-Position: refs/heads/master@{#300434}

Patch Set 1 #

Patch Set 2 : facepalm. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/shell/browser/layout_test/layout_test_browser_main.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
Mike West
TBRing you for this really stupid typo on my part. Thanks for catching it!
6 years, 2 months ago (2014-10-20 09:57:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/660473003/1
6 years, 2 months ago (2014-10-20 09:58:02 UTC) #3
marja
lgtm, woohoo, #include order check did something useful :)
6 years, 2 months ago (2014-10-20 09:59:03 UTC) #4
Mike West
On 2014/10/20 09:59:03, marja wrote: > lgtm, woohoo, #include order check did something useful :) ...
6 years, 2 months ago (2014-10-20 10:00:45 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/25829)
6 years, 2 months ago (2014-10-20 10:19:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/660473003/20001
6 years, 2 months ago (2014-10-21 07:36:41 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-21 08:07:14 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 08:08:02 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b49778b1f891e8d0ad5368041c1b8559be110d26
Cr-Commit-Position: refs/heads/master@{#300434}

Powered by Google App Engine
This is Rietveld 408576698