Put app shim IPC socket in a temporary directory. (Mac)

apps/app_shim/app_shim_host_manager_mac.mm

Index: apps/app_shim/app_shim_host_manager_mac.mm
diff --git a/apps/app_shim/app_shim_host_manager_mac.mm b/apps/app_shim/app_shim_host_manager_mac.mm
index eeaa114adea0e03b5921483ca98379a4ffeee43b..25200524f2b8a882af18733292389f7579cd5149 100644
--- a/apps/app_shim/app_shim_host_manager_mac.mm
+++ b/apps/app_shim/app_shim_host_manager_mac.mm
@@ -8,6 +8,7 @@
 #include "apps/app_shim/app_shim_host_mac.h"
 #include "base/bind.h"
 #include "base/command_line.h"
+#include "base/file_util.h"
 #include "base/files/file_path.h"
 #include "base/logging.h"
 #include "base/path_service.h"
@@ -15,7 +16,6 @@
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/mac/app_mode_common.h"
-#include "ipc/unix_domain_socket_util.h"
 
 using content::BrowserThread;
 
@@ -26,9 +26,12 @@ void CreateAppShimHost(const IPC::ChannelHandle& handle) {
   (new AppShimHost)->ServeChannel(handle);
 }
 
-}  // namespace
+void DeleteFile(base::FilePath path) {
+  if (!path.empty())
+    base::DeleteFile(path, true);
+}
 
-const base::FilePath* AppShimHostManager::g_override_user_data_dir_ = NULL;
+}  // namespace
 
 AppShimHostManager::AppShimHostManager() {}
 
@@ -42,29 +45,26 @@ void AppShimHostManager::Init() {
 
 AppShimHostManager::~AppShimHostManager() {
   apps::AppShimHandler::SetDefaultHandler(NULL);
+  factory_.reset();
+  BrowserThread::PostTask(
+      BrowserThread::FILE, FROM_HERE,
+      base::Bind(&DeleteFile, directory_in_tmp_));
 }
 
 void AppShimHostManager::InitOnFileThread() {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
   base::FilePath user_data_dir;
-  if (g_override_user_data_dir_) {
-    user_data_dir = *g_override_user_data_dir_;
-  } else if (!PathService::Get(chrome::DIR_USER_DATA, &user_data_dir)) {
-    LOG(ERROR) << "Couldn't get user data directory while creating App Shim "
-               << "Host manager.";
+  if (!PathService::Get(chrome::DIR_USER_DATA, &user_data_dir))
     return;
-  }
 
-  base::FilePath socket_path =
-      user_data_dir.Append(app_mode::kAppShimSocketName);
-  // This mirrors a check in unix_domain_socket_util.cc which will guarantee
-  // failure and spam log files on bots because they have deeply nested paths to
-  // |user_data_dir| when swarming. See http://crbug.com/240554. Shim tests that
-  // run on the bots must override the path using AppShimHostManagerTestApi.
-  if (socket_path.value().length() >= IPC::kMaxSocketNameLength &&
-      CommandLine::ForCurrentProcess()->HasSwitch(switches::kTestType)) {
+  // The socket path must be shorter than 128 chars (IPC::kMaxSocketNameLength).
+  // To accommodate this, we use a short path in /tmp/ that is generated from a
+  // hash of the user data dir.
+  base::FilePath socket_path = app_mode::GetShortSocketPath(user_data_dir);
+  directory_in_tmp_ = socket_path.DirName();

[tapted, 2013/11/22 06:50:43]

since this can become "." if socket_path.empty() [("".DirName() == ".")] [even
though we "know" that's impossible due to the way base64 works] I guess we
should do something here to stop us recursively deleting "." (hypothetically..
like someone substitutes a new implementation of base64?).


Perhaps `CHECK(!socket_path.empty());` on the line above.

[jackhou1, 2013/12/09 05:47:46]

Done.

+  file_util::CreateDirectory(directory_in_tmp_);
+  if (!base::PathIsWritable(directory_in_tmp_))
     return;

[tapted, 2013/11/22 06:50:43]

nit: maybe `directory_in_tmp_.clear()` before return?

[jackhou1, 2013/12/09 05:47:46]

Done.

-  }
 
   factory_.reset(new IPC::ChannelFactory(socket_path, this));
   BrowserThread::PostTask(