Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1230)

Unified Diff: chrome/common/mac/app_mode_common.h

Issue 66043003: Put app shim IPC socket in a temporary directory. (Mac) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Sync, rebase, git cl format Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « apps/app_shim/test/app_shim_host_manager_test_api_mac.cc ('k') | chrome/common/mac/app_mode_common.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/mac/app_mode_common.h
diff --git a/chrome/common/mac/app_mode_common.h b/chrome/common/mac/app_mode_common.h
index a88ded6598f762040990af264ee83f18409c6509..dd1915c668b3bec1fc91e620c0103ad45e7ee0ae 100644
--- a/chrome/common/mac/app_mode_common.h
+++ b/chrome/common/mac/app_mode_common.h
@@ -23,8 +23,11 @@ const AEEventClass kAEChromeAppClass = 'cApp';
const AEEventID kAEChromeAppPing = 'ping';
// The IPC socket used to communicate between app shims and Chrome will be
-// created under the user data directory with this name.
-extern const char kAppShimSocketName[];
+// created under a temporary directory with this name.
+extern const char kAppShimSocketShortName[];
+// A symlink to allow the app shim to find the socket will be created under the
+// user data dir with this name.
+extern const char kAppShimSocketSymlinkName[];
// Special app mode id used for the App Launcher.
extern const char kAppListModeId[];
@@ -127,6 +130,10 @@ struct ChromeAppModeInfo {
base::FilePath profile_dir;
};
+// Check that the socket and its parent directory have the correct permissions
+// and are owned by the user.
+void VerifySocketPermissions(const base::FilePath& socket_path);
+
} // namespace app_mode
#endif // CHROME_COMMON_MAC_APP_MODE_COMMON_H_
« no previous file with comments | « apps/app_shim/test/app_shim_host_manager_test_api_mac.cc ('k') | chrome/common/mac/app_mode_common.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698