Issue 66042: New baselines for new tests with the 42324:42364 merge....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 66042: New baselines for new tests with the 42324:42364 merge.... (Closed)

Created:
11 years, 8 months ago by Pam (message me for reviews)

Modified:
9 years, 5 months ago

Reviewers:
eroman

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

New baselines for new tests with the 42324:42364 merge. fixed-positioning-scrollbar-bug: minor differences in metrics function-apply-aliased-expected: different JS error messages BUG=9962 TEST=covered by layout tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13521

Patch Set 1 #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+48 lines, -0 lines)			Patch
A	webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/block/positioning/fixed-positioning-scrollbar-bug-expected.checksum	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/block/positioning/fixed-positioning-scrollbar-bug-expected.png	View	Binary file		0 comments	Download
A	webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/block/positioning/fixed-positioning-scrollbar-bug-expected.txt	View	1 chunk	+16 lines, -0 lines	0 comments	Download
A	webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/js/function-apply-aliased-expected.txt	View	1 chunk	+31 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

eroman

11 years, 8 months ago (2009-04-10 18:30:09 UTC) #2

LGTM.

Shouldn't the test expectations be part of this CL?
Also,
webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/js/function-apply-aliased-expected.txt

Is probably going to be the same for chromium-mac directory too, although I
guess it can be done in another pass :)

Expand Messages | Collapse Messages