Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 66041: This adds link[rel=icon] elements to the DOM UI html files for downloads and ... (Closed)

Created:
11 years, 8 months ago by arv (Not doing code reviews)
Modified:
9 years, 4 months ago
Reviewers:
Glen Murphy
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

This adds link[rel=icon] elements to the DOM UI html files for downloads and history. It also adds code to inline the resources for <link rel="icon"> elements BUG=9805 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13550

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M chrome/browser/resources/downloads.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/history.html View 1 chunk +1 line, -0 lines 0 comments Download
M tools/grit/grit/format/html_inline.py View 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
arv (Not doing code reviews)
This is waiting for my other CL which fixes data: URLs for favicons
11 years, 8 months ago (2009-04-10 19:43:07 UTC) #1
Glen Murphy
11 years, 8 months ago (2009-04-10 19:44:52 UTC) #2
LG

Powered by Google App Engine
This is Rietveld 408576698