Issue 66041: This adds link[rel=icon] elements to the DOM UI html files for downloads and ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 66041: This adds link[rel=icon] elements to the DOM UI html files for downloads and ... (Closed)

Created:
11 years, 8 months ago by arv (Not doing code reviews)

Modified:
9 years, 4 months ago

Reviewers:
Glen Murphy

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

This adds link[rel=icon] elements to the DOM UI html files for downloads and history. It also adds code to inline the resources for <link rel="icon"> elements BUG=9805 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13550

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -3 lines)			Patch
M	chrome/browser/resources/downloads.html	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/resources/history.html	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/grit/grit/format/html_inline.py	View	2 chunks	+6 lines, -3 lines	0 comments	Download

Total messages: 2 (0 generated)

arv (Not doing code reviews)

This is waiting for my other CL which fixes data: URLs for favicons

11 years, 8 months ago (2009-04-10 19:43:07 UTC) #1

LG