Chromium Code Reviews (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

Issue 6604012: [login_manager] Fix thread-safety issues at shutdown (Closed)

9 years, 9 months ago by Chris Masone
9 years, 7 months ago
Will Drewry
CC:, Chris Masone


[login_manager] Fix thread-safety issues at shutdown I was persisting the signed settings store to disk from the main thread at shutdown. In general, this work is only supposed to be done from the background thread. In practice, this was probably fine. In unit tests, it was possible that I could call store_->Persist() on one thread while I was already doing it on another thread. Boo me! BUG=12505 STATUS=Fixed TEST=unit tests Change-Id: I3d9b9639645712bc248f8e4be5336d16abce0295 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=ccc5ee0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -22 lines) Patch
M session_manager_service.h View 3 chunks +5 lines, -21 lines 0 comments Download
M View 2 chunks +12 lines, -1 line 0 comments Download


Total messages: 2 (0 generated)
Chris Masone
9 years, 9 months ago (2011-03-02 20:35:09 UTC) #1
Will Drewry
9 years, 9 months ago (2011-03-02 20:43:01 UTC) #2

Much cleaner fix than I was expecting when I read the problem :)

Powered by Google App Engine
This is Rietveld 408576698