Issue 66040: Re-baseline XFrameOptions tests....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 66040: Re-baseline XFrameOptions tests.... (Closed)

Created:
11 years, 8 months ago by Pam (message me for reviews)

Modified:
9 years, 5 months ago

Reviewers:
abarth-chromium

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Re-baseline XFrameOptions tests. It looks to me like we could use to modify our willSendRequest implementation to add in a "main document URL" report for greatest parity with WebKit's results, but in the meantime we can use our current message. BUG=9962 TEST=covered by layout tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13519

Patch Set 1 #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+76 lines, -0 lines)			Patch
A	webkit/data/layout_tests/platform/chromium-win/LayoutTests/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt	View	1 chunk	+10 lines, -0 lines	0 comments	Download
A	webkit/data/layout_tests/platform/chromium-win/LayoutTests/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt	View	1 chunk	+12 lines, -0 lines	0 comments	Download
A	webkit/data/layout_tests/platform/chromium-win/LayoutTests/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt	View	1 chunk	+12 lines, -0 lines	0 comments	Download
A	webkit/data/layout_tests/platform/chromium-win/LayoutTests/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow-expected.txt	View	1 chunk	+10 lines, -0 lines	0 comments	Download
A	webkit/data/layout_tests/platform/chromium-win/LayoutTests/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt	View	1 chunk	+12 lines, -0 lines	0 comments	Download
A	webkit/data/layout_tests/platform/chromium-win/LayoutTests/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-allow-expected.txt	View	1 chunk	+10 lines, -0 lines	0 comments	Download
A	webkit/data/layout_tests/platform/chromium-win/LayoutTests/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt	View	1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Pam (message me for reviews)

Please take a close look at these. I'm swimming in murky waters here -- our ...

11 years, 8 months ago (2009-04-10 18:02:28 UTC) #1

abarth-chromium

11 years, 8 months ago (2009-04-10 18:08:48 UTC) #2

LGTM.  The functionality looks right here.  It's possible we could improve our
error messages, but I don't see that as a big deal.

Expand Messages | Collapse Messages