Chromium Code Reviews
Help | Chromium Project | Sign in
(20)

Issue 660396: Fix a CHECK() being hit when the safebrowsing check fires. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 1 month ago by eroman
Modified:
2 years, 10 months ago
Reviewers:
wtc
CC:
chromium-reviews_chromium.org, jam+cc_chromium.org, brettw+cc_chromium.org, Paul Godavari, darin-cc_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Fix a CHECK() being hit when the safebrowsing check times out (passing in empty URL but expecting the deferred URL).

BUG=37195, 33572
TBR=wtc

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=40426

Patch Set 1 #

Patch Set 2 : Add a log message #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Lint Patch
M chrome/browser/renderer_host/safe_browsing_resource_handler.cc View 1 2 chunks +3 lines, -2 lines 2 comments 0 errors Download
Commit:

Messages

Total messages: 3
eroman
4 years, 1 month ago #1
wtc
LGTM. http://codereview.chromium.org/660396/diff/1003/1004 File chrome/browser/renderer_host/safe_browsing_resource_handler.cc (right): http://codereview.chromium.org/660396/diff/1003/1004#newcode150 chrome/browser/renderer_host/safe_browsing_resource_handler.cc:150: CHECK(url == deferred_url_) << "Was expecting: " << ...
4 years, 1 month ago #2
eroman
4 years, 1 month ago #3
http://codereview.chromium.org/660396/diff/1003/1004
File chrome/browser/renderer_host/safe_browsing_resource_handler.cc (right):

http://codereview.chromium.org/660396/diff/1003/1004#newcode150
chrome/browser/renderer_host/safe_browsing_resource_handler.cc:150: CHECK(url ==
deferred_url_) << "Was expecting: " << deferred_url_
On 2010/03/02 21:37:08, wtc wrote:
> If the |url| argument must be equal to the |deferred_url_|
> member, why do we still need the |url| argument?

The redirect bug would be failing in this method, since it had a mismatch
between what the URL was completing for and what it was waiting for. The check
is to guard against those sort of mistakes. Until this code is unit tested, I
think such checks are necessary as a minimum bar for correctness.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6