Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 660393: Fix for pyauto cross compile build break on linux. (Closed)

Created:
10 years, 9 months ago by zel
Modified:
9 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Fixed cross compile build break on linux. For now, pyauto can only be built on linux where host and target architecture are the same. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=40428

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/chrome_tests.gypi View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 4 (0 generated)
zel
For now, pyauto can only be built on linux where host and target architecture are ...
10 years, 9 months ago (2010-03-02 19:50:24 UTC) #1
Nirnimesh
LGTM http://codereview.chromium.org/660393/diff/1/2 File chrome/chrome_tests.gypi (right): http://codereview.chromium.org/660393/diff/1/2#newcode1867 chrome/chrome_tests.gypi:1867: ['OS=="mac" or chromeos==1 or (OS=="linux" and target_arch==host_arch and ...
10 years, 9 months ago (2010-03-02 20:05:13 UTC) #2
Nirnimesh
Hmm.. Looks like gyp files don't observe the 80 char per line limit. Never mind. ...
10 years, 9 months ago (2010-03-02 20:10:57 UTC) #3
Lei Zhang
10 years, 9 months ago (2010-03-02 22:17:41 UTC) #4
On 2010/03/02 20:10:57, Nirnimesh wrote:
> Hmm.. Looks like gyp files don't observe the 80 char per line limit. Never
mind.
> 
> LGTM

FYI, I have a fix that works by detecting the arch of
<(sysroot)/usr/bin/python<(python_ver) and disable pyauto if there's a mismatch.
I'll send out a review later today when I get back to my work computer.

Powered by Google App Engine
This is Rietveld 408576698