Fix for pyauto cross compile build break on linux.

Fixed cross compile build break on linux. For now, pyauto can only be built on linux where host and target architecture are the same. 


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=40428

[zel, 2010-03-02 19:50:24]

For now, pyauto can only be built on linux where host and target architecture
are the same.

We will have to figure out how to make the build environment similar to
ChromeOS' chroot build settings if we want to make 32bit bits on 64bit machine
and vice versa.

[Nirnimesh, 2010-03-02 20:05:13]

LGTM

http://codereview.chromium.org/660393/diff/1/2
File chrome/chrome_tests.gypi (right):

http://codereview.chromium.org/660393/diff/1/2#newcode1867
chrome/chrome_tests.gypi:1867: ['OS=="mac" or chromeos==1 or (OS=="linux" and
target_arch==host_arch and (target_arch!="x64" or linux_fpic==1))', {
Maybe spread over 2 lines?

['OS=="mac" or chromeos==1 or (OS=="linux" and target_arch==host_arch and  
'(target_arch!="x64" or linux_fpic==1))', {

[Nirnimesh, 2010-03-02 20:10:57]

Hmm.. Looks like gyp files don't observe the 80 char per line limit. Never mind.

LGTM

[Lei Zhang, 2010-03-02 22:17:41]

On 2010/03/02 20:10:57, Nirnimesh wrote:
> Hmm.. Looks like gyp files don't observe the 80 char per line limit. Never
mind.
> 
> LGTM

FYI, I have a fix that works by detecting the arch of
<(sysroot)/usr/bin/python<(python_ver) and disable pyauto if there's a mismatch.
I'll send out a review later today when I get back to my work computer.