aw: Do not limit number of tiles

aw: Do not limit number of tiles

By making the limit unrealistically high.

BUG=426548
Committed: https://crrev.com/9448dfa74ccf2ecbe7aa8be87701d5fc9fedf215
Cr-Commit-Position: refs/heads/master@{#300991}

[boliu, 2014-10-23 20:12:03]

boliu@chromium.org changed reviewers:
+ hush@chromium.org

[benm (inactive), 2014-10-23 20:19:06]

Can we use a special value (-1?) To actually indicate that there should be
no limit?

On Thu, 23 Oct 2014 21:12 null <boliu@chromium.org> wrote:

> Reviewers: hush,
>
> Description:
> aw: Do not limit number of tiles
>
> By making the limit unrealistically high.
>
> BUG=426548
>
> Please review this at https://codereview.chromium.org/660383004/
>
> Base URL: https://chromium.googlesource.com/chromium/src.git@master
>
> Affected files (+3, -2 lines):
>    M android_webview/browser/browser_view_renderer.cc
>
>
> Index: android_webview/browser/browser_view_renderer.cc
> diff --git a/android_webview/browser/browser_view_renderer.cc
> b/android_webview/browser/browser_view_renderer.cc
> index
> cbe31857a4dab1eab93ab4dc6f94858ad165e20d..3b43ad4d9751835da6ba226bd6eeea
> 5ec6141189
> 100644
> --- a/android_webview/browser/browser_view_renderer.cc
> +++ b/android_webview/browser/browser_view_renderer.cc
> @@ -61,8 +61,9 @@ void BrowserViewRenderer::CalculateTileMemoryPolicy() {
>       g_memory_override_in_bytes *= 1024 * 1024;
>     }
>
> -  // Also use a high tile limit since there are no file descriptor issues.
> -  GlobalTileManager::GetInstance()->SetTileLimit(1000);
> +  // There is no need to limit number of tiles, so use an effectively
> unlimited
> +  // value as the limit.
> +  GlobalTileManager::GetInstance()->SetTileLimit(10 * 1000 * 1000);
>   }
>
>   BrowserViewRenderer::BrowserViewRenderer(
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[boliu, 2014-10-23 20:20:34]

On 2014/10/23 20:19:06, benm wrote:
> Can we use a special value (-1?) To actually indicate that there should be
> no limit?

This is for merging to m39. Going forward, I'd like to remove said code
altogether.

[hush (inactive), 2014-10-23 20:49:52]

lgtm

[boliu, 2014-10-23 21:03:24]

The CQ bit was checked by boliu@chromium.org

[commit-bot: I haz the power, 2014-10-23 21:04:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/660383004/1

[commit-bot: I haz the power, 2014-10-23 21:22:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-23 21:22:36]

Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)

[boliu, 2014-10-23 21:43:32]

The CQ bit was checked by boliu@chromium.org

[commit-bot: I haz the power, 2014-10-23 21:45:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/660383004/1

[commit-bot: I haz the power, 2014-10-23 23:55:47]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2014-10-23 23:56:36]

Patchset 1 (id:??) landed as
https://crrev.com/9448dfa74ccf2ecbe7aa8be87701d5fc9fedf215
Cr-Commit-Position: refs/heads/master@{#300991}