chrome/common/extensions/docs/server2/subversion_file_system.py - Issue 660383002: Docserver: Persist stat cache for versioned file systems

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/docs/server2/subversion_file_system.py

Issue 660383002: Docserver: Persist stat cache for versioned file systems (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: change caching strategy, better refresh cycle synchronization Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/docs/server2/refresh_tracker.py ('K') | « chrome/common/extensions/docs/server2/samples_data_source.py ('k') | chrome/common/extensions/docs/server2/test_file_system.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/docs/server2/subversion_file_system.py

diff --git a/chrome/common/extensions/docs/server2/subversion_file_system.py b/chrome/common/extensions/docs/server2/subversion_file_system.py

index 949bca9bb3a960713584a79db5941abc15e012d3..a2f0438dc32af4130f01ed31bd9c109429cb72e0 100644

--- a/chrome/common/extensions/docs/server2/subversion_file_system.py

+++ b/chrome/common/extensions/docs/server2/subversion_file_system.py

@@ -201,7 +201,7 @@ class SubversionFileSystem(FileSystem):

return Future(callback=resolve)

- def GetIdentity(self):

+ def GetStableIdentity(self):

# NOTE: no revision here, since it would mess up the caching of reads. It

# probably doesn't matter since all the caching classes will use the result

# of Stat to decide whether to re-read - and Stat has a ceiling of the