chrome/common/extensions/docs/server2/gcs_file_system.py - Issue 660383002: Docserver: Persist stat cache for versioned file systems

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/docs/server2/gcs_file_system.py

Issue 660383002: Docserver: Persist stat cache for versioned file systems (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: change caching strategy, better refresh cycle synchronization Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/docs/server2/file_system.py ('K') | « chrome/common/extensions/docs/server2/file_system.py ('k') | chrome/common/extensions/docs/server2/github_file_system.py » ('j') | chrome/common/extensions/docs/server2/handler.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/docs/server2/gcs_file_system.py

diff --git a/chrome/common/extensions/docs/server2/gcs_file_system.py b/chrome/common/extensions/docs/server2/gcs_file_system.py

index 36f28fa08f33f2d3ce73cfa4a2f0d86fa0bc7ee3..c4b30ea143de4652a2dedc4093157c340ac0d606 100644

--- a/chrome/common/extensions/docs/server2/gcs_file_system.py

+++ b/chrome/common/extensions/docs/server2/gcs_file_system.py

@@ -55,8 +55,8 @@ def _CreateStatInfo(bucket, path):

try:

last_commit = _ReadFile(last_commit_file)

if IsDirectory(full_path):

- child_versions = dict((filename, last_commit)

- for filename in _ListDir(full_path))

+ child_versions = dict((filename, last_commit)

+ for filename in _ListDir(full_path))

else:

child_versions = None

return StatInfo(last_commit, child_versions)

@@ -109,7 +109,7 @@ class CloudStorageFileSystem(FileSystem):

self._warnAboutAuthError()

raise

- def GetIdentity(self):

+ def GetStableIdentity(self):

return '@'.join((self.__class__.__name__, StringIdentity(self._bucket)))

def __repr__(self):