Docserver: Persist stat cache for versioned file systems

chrome/common/extensions/docs/server2/host_file_system_provider.py

Index: chrome/common/extensions/docs/server2/host_file_system_provider.py
diff --git a/chrome/common/extensions/docs/server2/host_file_system_provider.py b/chrome/common/extensions/docs/server2/host_file_system_provider.py
index b19592e2e696c00ac521036a86a40da4f68ce1f5..f69759f35b3ce98bb81e78bbaf7e0e68f0b8358a 100644
--- a/chrome/common/extensions/docs/server2/host_file_system_provider.py
+++ b/chrome/common/extensions/docs/server2/host_file_system_provider.py
@@ -21,7 +21,8 @@ class HostFileSystemProvider(object):
                pinned_commit=None,
                default_master_instance=None,
                offline=False,
-               constructor_for_test=None):
+               constructor_for_test=None,
+               cache_only=False):

[not at google - send to devlin, 2014/10/20 21:06:57]

Document this parameter (so I know what it means).

[Ken Rockot(use gerrit already), 2014/10/22 03:19:54]

Done.

     '''
     |object_store_creator|
       Provides caches for file systems that need one.
@@ -41,6 +42,7 @@ class HostFileSystemProvider(object):
     self._default_master_instance = default_master_instance
     self._offline = offline
     self._constructor_for_test = constructor_for_test
+    self._cache_only = cache_only
 
   @memoize
   def GetMaster(self, commit=None):
@@ -59,10 +61,6 @@ class HostFileSystemProvider(object):
       if self._default_master_instance is not None:
         return self._default_master_instance
       return self._Create('master', commit=self._pinned_commit)
-    if self._pinned_commit is not None:
-      # XXX(ahernandez): THIS IS WRONG. Should be
-      # commit = Oldest(commit, self._pinned_commit).
-      commit = min(commit, self._pinned_commit)
     return self._Create('master', commit=commit)
 
   @memoize
@@ -91,7 +89,8 @@ class HostFileSystemProvider(object):
       file_system = GitilesFileSystem.Create(branch=branch, commit=commit)
     if self._offline:
       file_system = OfflineFileSystem(file_system)
-    return CachingFileSystem(file_system, self._object_store_creator)
+    return CachingFileSystem(file_system, self._object_store_creator,
+        fail_on_miss=self._cache_only)
 
   @staticmethod
   def ForLocal(object_store_creator, **optargs):