| OLD | NEW |
| 1 # Copyright 2013 The Chromium Authors. All rights reserved. | 1 # Copyright 2013 The Chromium Authors. All rights reserved. |
| 2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
| 3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
| 4 | 4 |
| 5 from branch_utility import BranchUtility | 5 from branch_utility import BranchUtility |
| 6 from commit_tracker import CommitTracker |
| 6 from compiled_file_system import CompiledFileSystem | 7 from compiled_file_system import CompiledFileSystem |
| 7 from environment import IsDevServer, IsReleaseServer | 8 from environment import IsDevServer, IsReleaseServer |
| 8 from github_file_system_provider import GithubFileSystemProvider | 9 from github_file_system_provider import GithubFileSystemProvider |
| 9 from host_file_system_provider import HostFileSystemProvider | 10 from host_file_system_provider import HostFileSystemProvider |
| 10 from third_party.json_schema_compiler.memoize import memoize | 11 from third_party.json_schema_compiler.memoize import memoize |
| 11 from render_servlet import RenderServlet | 12 from render_servlet import RenderServlet |
| 12 from object_store_creator import ObjectStoreCreator | 13 from object_store_creator import ObjectStoreCreator |
| 13 from server_instance import ServerInstance | 14 from server_instance import ServerInstance |
| 14 from gcs_file_system_provider import CloudStorageFileSystemProvider | 15 from gcs_file_system_provider import CloudStorageFileSystemProvider |
| 15 | 16 |
| 17 |
| 16 class InstanceServletRenderServletDelegate(RenderServlet.Delegate): | 18 class InstanceServletRenderServletDelegate(RenderServlet.Delegate): |
| 17 '''AppEngine instances should never need to call out to Gitiles. That should | 19 '''AppEngine instances should never need to call out to Gitiles. That should |
| 18 only ever be done by the cronjobs, which then write the result into | 20 only ever be done by the cronjobs, which then write the result into |
| 19 DataStore, which is as far as instances look. To enable this, crons can pass | 21 DataStore, which is as far as instances look. To enable this, crons can pass |
| 20 a custom (presumably online) ServerInstance into Get(). | 22 a custom (presumably online) ServerInstance into Get(). |
| 21 | 23 |
| 22 Why? Gitiles is slow and a bit flaky. Refresh jobs failing is annoying but | 24 Why? Gitiles is slow and a bit flaky. Refresh jobs failing is annoying but |
| 23 temporary. Instances failing affects users, and is really bad. | 25 temporary. Instances failing affects users, and is really bad. |
| 24 | 26 |
| 25 Anyway - to enforce this, we actually don't give instances access to | 27 Anyway - to enforce this, we actually don't give instances access to |
| 26 Gitiles. If anything is missing from datastore, it'll be a 404. If the | 28 Gitiles. If anything is missing from datastore, it'll be a 404. If the |
| 27 cronjobs don't manage to catch everything - uhoh. On the other hand, we'll | 29 cronjobs don't manage to catch everything - uhoh. On the other hand, we'll |
| 28 figure it out pretty soon, and it also means that legitimate 404s are caught | 30 figure it out pretty soon, and it also means that legitimate 404s are caught |
| 29 before a round trip to Gitiles. | 31 before a round trip to Gitiles. |
| 30 ''' | 32 ''' |
| 31 def __init__(self, delegate): | 33 def __init__(self, delegate): |
| 32 self._delegate = delegate | 34 self._delegate = delegate |
| 33 | 35 |
| 34 @memoize | 36 @memoize |
| 35 def CreateServerInstance(self): | 37 def CreateServerInstance(self): |
| 36 object_store_creator = ObjectStoreCreator(start_empty=False) | 38 object_store_creator = ObjectStoreCreator(start_empty=False) |
| 37 branch_utility = self._delegate.CreateBranchUtility(object_store_creator) | 39 branch_utility = self._delegate.CreateBranchUtility(object_store_creator) |
| 40 commit_tracker = CommitTracker(object_store_creator) |
| 38 # In production have offline=True so that we can catch cron errors. In | 41 # In production have offline=True so that we can catch cron errors. In |
| 39 # development it's annoying to have to run the cron job, so offline=False. | 42 # development it's annoying to have to run the cron job, so offline=False. |
| 40 # Note that offline=True if running on any appengine server due to | 43 # Note that offline=True if running on any appengine server due to |
| 41 # http://crbug.com/345361. | 44 # http://crbug.com/345361. |
| 42 host_file_system_provider = self._delegate.CreateHostFileSystemProvider( | 45 host_file_system_provider = self._delegate.CreateHostFileSystemProvider( |
| 43 object_store_creator, | 46 object_store_creator, |
| 44 offline=not (IsDevServer() or IsReleaseServer())) | 47 offline=not (IsDevServer() or IsReleaseServer()), |
| 48 pinned_commit=commit_tracker.Get('master').Get(), |
| 49 cache_only=True) |
| 45 github_file_system_provider = self._delegate.CreateGithubFileSystemProvider( | 50 github_file_system_provider = self._delegate.CreateGithubFileSystemProvider( |
| 46 object_store_creator) | 51 object_store_creator) |
| 47 return ServerInstance(object_store_creator, | 52 return ServerInstance(object_store_creator, |
| 48 CompiledFileSystem.Factory(object_store_creator), | 53 CompiledFileSystem.Factory(object_store_creator), |
| 49 branch_utility, | 54 branch_utility, |
| 50 host_file_system_provider, | 55 host_file_system_provider, |
| 51 github_file_system_provider, | 56 github_file_system_provider, |
| 52 CloudStorageFileSystemProvider(object_store_creator)) | 57 CloudStorageFileSystemProvider(object_store_creator)) |
| 53 | 58 |
| 54 class InstanceServlet(object): | 59 class InstanceServlet(object): |
| (...skipping 14 matching lines...) Expand all Loading... |
| 69 return GithubFileSystemProvider(object_store_creator) | 74 return GithubFileSystemProvider(object_store_creator) |
| 70 | 75 |
| 71 @staticmethod | 76 @staticmethod |
| 72 def GetConstructor(delegate_for_test=None): | 77 def GetConstructor(delegate_for_test=None): |
| 73 render_servlet_delegate = InstanceServletRenderServletDelegate( | 78 render_servlet_delegate = InstanceServletRenderServletDelegate( |
| 74 delegate_for_test or InstanceServlet.Delegate()) | 79 delegate_for_test or InstanceServlet.Delegate()) |
| 75 return lambda request: RenderServlet(request, render_servlet_delegate) | 80 return lambda request: RenderServlet(request, render_servlet_delegate) |
| 76 | 81 |
| 77 # NOTE: if this were a real Servlet it would implement a Get() method, but | 82 # NOTE: if this were a real Servlet it would implement a Get() method, but |
| 78 # GetConstructor returns an appropriate lambda function (Request -> Servlet). | 83 # GetConstructor returns an appropriate lambda function (Request -> Servlet). |
| OLD | NEW |