Docserver: Persist stat cache for versioned file systems

chrome/common/extensions/docs/server2/gitiles_file_system.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 
 from base64 import b64decode
 from itertools import izip
 import json
 import logging
 import posixpath
@@ skipping 215 matching lines @@
         return stat_info
       if filename not in stat_info.child_versions:
         raise FileNotFoundError(
             '%s from %s was not in child versions for Stat' % (filename, path))
       return StatInfo(stat_info.child_versions[filename])
 
     fetch_future = self._FetchAsync(ToDirectory(dir_) + _JSON_FORMAT)
     return self._ResolveFetchContent(path, fetch_future).Then(stat)
 
   def GetIdentity(self):
-    # NOTE: Do not use commit information to create the string identity.
-    # Doing so will mess up caching.
-    if self._commit is None and self._branch != 'master':
+    '''The identity is always the same for GitilesFileSystems designated to
+    master, even if they are pinned to a specific commit.'''

[not at google - send to devlin, 2014/10/24 00:04:51]

This seems more like a code comment than a docstring, so it should be # comment.

and nit: I prefer putting those inside the conditional that they apply to,
especially in a chain of if..elif..else.

[Ken Rockot(use gerrit already), 2014/10/24 21:26:53]

Done.

+    if self._branch == 'master':
+      str_id = '%s/%s/master' % (GITILES_BASE, GITILES_SRC_ROOT)
+    elif self._commit is not None:
+      str_id = '%s/%s/%s' % (GITILES_BASE, GITILES_SRC_ROOT, self._commit)
+    else:
       str_id = '%s/%s/%s/%s' % (
           GITILES_BASE, GITILES_SRC_ROOT, GITILES_BRANCHES_PATH, self._branch)

[not at google - send to devlin, 2014/10/24 00:04:51]

These all share GITILES_BASE and GITILES_SRC_ROOT as their first arguments...
might be easier to just prepend them within that StringIdentity call?

[Ken Rockot(use gerrit already), 2014/10/24 21:26:53]

Done.

-    else:
-      str_id = '%s/%s' % (GITILES_BASE, GITILES_SRC_ROOT)
     return '@'.join((self.__class__.__name__, StringIdentity(str_id)))
+
+  def GetVersion(self):
+    if self._commit is not None:
+      return self._commit
+    return None

[not at google - send to devlin, 2014/10/24 00:04:51]

return self._commit ?

[Ken Rockot(use gerrit already), 2014/10/24 21:26:54]

Lol. Right. Done.