native_client_sdk/src/libraries/nacl_io/memfs/mem_fs.cc - Issue 660353003: [NaCl SDK] nacl_io: Fix utime() on directories.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: native_client_sdk/src/libraries/nacl_io/memfs/mem_fs.cc

Issue 660353003: [NaCl SDK] nacl_io: Fix utime() on directories. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: native_client_sdk/src/libraries/nacl_io/memfs/mem_fs.cc

diff --git a/native_client_sdk/src/libraries/nacl_io/memfs/mem_fs.cc b/native_client_sdk/src/libraries/nacl_io/memfs/mem_fs.cc

index 38c5070546306a4a8b9eeeeece60124adfc36ab8..70da25ce58fa96593570ca2e0f9f22c82df7f70a 100644

--- a/native_client_sdk/src/libraries/nacl_io/memfs/mem_fs.cc

+++ b/native_client_sdk/src/libraries/nacl_io/memfs/mem_fs.cc

@@ -105,10 +105,6 @@ Error MemFs::OpenWithMode(const Path& path, int open_flags, mode_t mode,

} else {

// Opening an existing file.

- // Directories can only be opened read-only.

- if (node->IsaDir() && (open_flags & 3) != O_RDONLY)

- return EISDIR;

// If we were expected to create it exclusively, fail

if (open_flags & O_EXCL)

return EEXIST;