[NaCl SDK] nacl_io: Fix utime() on directories.

native_client_sdk/src/tests/nacl_io_test/kernel_proxy_test.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <errno.h>
 #include <fcntl.h>
 #include <pthread.h>
 #include <stdio.h>
 #include <sys/stat.h>
 #include <sys/types.h>
@@ skipping 531 matching lines @@
   EXPECT_TRUE(S_ISDIR(buf.st_mode));
 
   EXPECT_EQ(-1, ki_lstat("/no-such-file", &buf));
   EXPECT_EQ(ENOENT, errno);
 
   // Still legal to stat a file that is write-only.
   EXPECT_EQ(0, ki_chmod("/foo", 0222));
   EXPECT_EQ(0, ki_lstat("/foo", &buf));
 }
 
+TEST_F(KernelProxyTest, OpenDirectory) {
+  // Opening a directory for read should succeed.
+  int fd = ki_open("/", O_RDONLY, 0);
+  ASSERT_GT(fd, -1);
+
+  // Opening a directory for write should fail.
+  EXPECT_EQ(-1, ki_open("/", O_RDWR, 0));
+  EXPECT_EQ(errno, EISDIR);
+  EXPECT_EQ(-1, ki_open("/", O_WRONLY, 0));
+  EXPECT_EQ(errno, EISDIR);
+}
+
 TEST_F(KernelProxyTest, OpenWithMode) {
   int fd = ki_open("/foo", O_CREAT | O_RDWR, 0723);
   ASSERT_GT(fd, -1);
 
   struct stat buf;
   EXPECT_EQ(0, ki_lstat("/foo", &buf));
-  EXPECT_EQ(0723, buf.st_mode & ~S_IFMT);
+  EXPECT_EQ(0723, buf.st_mode & 0777);
 }
 
 TEST_F(KernelProxyTest, CreateWronlyWithReadOnlyMode) {
   int fd = ki_open("/foo", O_CREAT | O_WRONLY, 0444);
   ASSERT_GT(fd, -1);
 }
 
 TEST_F(KernelProxyTest, UseAfterClose) {
   int fd = ki_open("/dummy", O_CREAT | O_WRONLY, 0777);
   ASSERT_GT(fd, -1);
@@ skipping 10 matching lines @@
   times[1].tv_sec = 3000;
   times[1].tv_usec = 4000;
 
   int fd = ki_open("/dummy", O_CREAT | O_WRONLY, 0222);
   ASSERT_GT(fd, -1);
   EXPECT_EQ(0, ki_close(fd));
 
   // utime should work if the file is write-only.
   EXPECT_EQ(0, ki_utimes("/dummy", times));
 
+  // utime should work directories (we can never be opened for write)
+  EXPECT_EQ(0, ki_utimes("/", times));
+
   // or if the file is read-only.
   EXPECT_EQ(0, ki_chmod("/dummy", 0444));
   EXPECT_EQ(0, ki_utimes("/dummy", times));
 
   // times can be NULL. In that case the access/mod times will be set to the
   // current time.
   struct timeval tm;
   EXPECT_EQ(0, gettimeofday(&tm, NULL));
 
   EXPECT_EQ(0, ki_utimes("/dummy", NULL));
@@ skipping 42 matching lines @@
   EXPECT_EQ(0, oldmask);
 
   int fd = ki_open("/foo", O_CREAT | O_RDONLY, 0666);
   ASSERT_GT(fd, -1);
   ki_close(fd);
 
   EXPECT_EQ(0, ki_mkdir("/dir", 0777));
 
   struct stat buf;
   EXPECT_EQ(0, ki_stat("/foo", &buf));
-  EXPECT_EQ(0444, buf.st_mode & ~S_IFMT);
+  EXPECT_EQ(0444, buf.st_mode & 0777);
 
   EXPECT_EQ(0, ki_stat("/dir", &buf));
-  EXPECT_EQ(0555, buf.st_mode & ~S_IFMT);
+  EXPECT_EQ(0555, buf.st_mode & 0777);
 
   EXPECT_EQ(0222, ki_umask(0));
 }
 
 namespace {
 
 StringMap_t g_string_map;
 bool g_fs_ioctl_called;
 int g_fs_dev;
 
@@ skipping 315 matching lines @@
 
   int fd = ki_open("/dummy", O_RDONLY, 0);
   EXPECT_NE(0, fd);
 
   char buf[20];
   EXPECT_EQ(-1, ki_read(fd, &buf[0], 20));
   // The Filesystem should be able to return whatever error it wants and have it
   // propagate through.
   EXPECT_EQ(1234, errno);
 }