Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 660353002: Remove dead declarations for a nonexistent class. (Closed)

Created:
6 years, 2 months ago by palmer
Modified:
6 years, 2 months ago
CC:
chromium-reviews, benquan, browser-components-watch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, erikwright+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove dead declarations for a nonexistent class. TestingAutomationProvider is dead, Jim. BUG=154997 TBR=jam,sky Committed: https://crrev.com/f5c85cf69f46e8231da8d292cbae29d5241ddadf Cr-Commit-Position: refs/heads/master@{#300200}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M base/threading/thread_restrictions.h View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/autofill/core/browser/personal_data_manager.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
palmer
PTAL, estade, sky, and jam, for trivial OWNERS review.
6 years, 2 months ago (2014-10-17 21:37:46 UTC) #2
Evan Stade
components/autofill/core/browser/personal_data_manager.h lgtm
6 years, 2 months ago (2014-10-17 22:04:33 UTC) #3
Charlie Reis
Hooray for dead code removal. LGTM.
6 years, 2 months ago (2014-10-17 22:06:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/660353002/1
6 years, 2 months ago (2014-10-17 23:51:36 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-18 02:10:53 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-18 02:11:38 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f5c85cf69f46e8231da8d292cbae29d5241ddadf
Cr-Commit-Position: refs/heads/master@{#300200}

Powered by Google App Engine
This is Rietveld 408576698