chrome/browser/media_galleries/media_galleries_permissions_unittest.cc - Issue 660343006: Standardize usage of virtual/override/final in chrome/browser/media_galleries

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media_galleries/media_galleries_permissions_unittest.cc

Issue 660343006: Standardize usage of virtual/override/final in chrome/browser/media_galleries (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/media_galleries/media_galleries_permission_controller.h ('k') | chrome/browser/media_galleries/media_galleries_preferences.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media_galleries/media_galleries_permissions_unittest.cc

diff --git a/chrome/browser/media_galleries/media_galleries_permissions_unittest.cc b/chrome/browser/media_galleries/media_galleries_permissions_unittest.cc

index f64ad16e423e3252d9c3d3743f6a3e46b31eab8e..487daeb2baaa1898c354153aa7338cde9e9a233f 100644

--- a/chrome/browser/media_galleries/media_galleries_permissions_unittest.cc

+++ b/chrome/browser/media_galleries/media_galleries_permissions_unittest.cc

@@ -57,7 +57,7 @@ class MediaGalleriesPermissionsTest : public extensions::ExtensionPrefsTest {

testing::Test::TearDown();

}

- virtual void Initialize() override {

+ void Initialize() override {

file_thread_.Start();

ASSERT_TRUE(storage_monitor::TestStorageMonitor::CreateAndInstall());

@@ -110,7 +110,7 @@ class MediaGalleriesPermissionsTest : public extensions::ExtensionPrefsTest {

Verify();

}

- virtual void Verify() override {

+ void Verify() override {

struct TestData {

std::string* id;

std::vector<MediaGalleryPermission>* expectation;