chrome/browser/media_galleries/media_file_system_registry.h - Issue 660343006: Standardize usage of virtual/override/final in chrome/browser/media_galleries

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media_galleries/media_file_system_registry.h

Issue 660343006: Standardize usage of virtual/override/final in chrome/browser/media_galleries (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/media_galleries/mac/mtp_device_delegate_impl_mac.mm ('k') | chrome/browser/media_galleries/media_file_system_registry.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media_galleries/media_file_system_registry.h

diff --git a/chrome/browser/media_galleries/media_file_system_registry.h b/chrome/browser/media_galleries/media_file_system_registry.h

index 6398e34b2236a864487698b6c91a5883d1f5dcdf..2b38233ad88b746e34bf2ac7dfc8938cbf3625af 100644

--- a/chrome/browser/media_galleries/media_file_system_registry.h

+++ b/chrome/browser/media_galleries/media_file_system_registry.h

@@ -73,7 +73,7 @@ class MediaFileSystemRegistry

public MediaGalleriesPreferences::GalleryChangeObserver {

public:

MediaFileSystemRegistry();

- virtual ~MediaFileSystemRegistry();

+ ~MediaFileSystemRegistry() override;

// Passes to |callback| the list of media filesystem IDs and paths for a

// given RVH.

@@ -99,7 +99,7 @@ class MediaFileSystemRegistry

GalleryWatchManager* gallery_watch_manager();

// RemovableStorageObserver implementation.

- virtual void OnRemovableStorageDetached(

+ void OnRemovableStorageDetached(

const storage_monitor::StorageInfo& info) override;

private:

@@ -115,11 +115,11 @@ class MediaFileSystemRegistry

// Map a profile and extension to the ExtensionGalleriesHost.

typedef std::map<Profile*, ExtensionHostMap> ExtensionGalleriesHostMap;

- virtual void OnPermissionRemoved(MediaGalleriesPreferences* pref,

- const std::string& extension_id,

- MediaGalleryPrefId pref_id) override;

- virtual void OnGalleryRemoved(MediaGalleriesPreferences* pref,

- MediaGalleryPrefId pref_id) override;

+ void OnPermissionRemoved(MediaGalleriesPreferences* pref,

+ const std::string& extension_id,

+ MediaGalleryPrefId pref_id) override;

+ void OnGalleryRemoved(MediaGalleriesPreferences* pref,

+ MediaGalleryPrefId pref_id) override;

// Look up or create the extension gallery host.

ExtensionGalleriesHost* GetExtensionGalleryHost(