chrome/browser/media_galleries/fileapi/safe_media_metadata_parser.h - Issue 660343006: Standardize usage of virtual/override/final in chrome/browser/media_galleries

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media_galleries/fileapi/safe_media_metadata_parser.h

Issue 660343006: Standardize usage of virtual/override/final in chrome/browser/media_galleries (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/media_galleries/fileapi/safe_iapps_library_parser.h ('k') | chrome/browser/media_galleries/fileapi/safe_picasa_album_table_reader.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media_galleries/fileapi/safe_media_metadata_parser.h

diff --git a/chrome/browser/media_galleries/fileapi/safe_media_metadata_parser.h b/chrome/browser/media_galleries/fileapi/safe_media_metadata_parser.h

index 1e5b8a7bc956176a15c0056fc8ebb335b25eb2fc..ac18b80bb8045ddb5f3f90431a1d9e1f2639aa65 100644

--- a/chrome/browser/media_galleries/fileapi/safe_media_metadata_parser.h

+++ b/chrome/browser/media_galleries/fileapi/safe_media_metadata_parser.h

@@ -53,7 +53,7 @@ class SafeMediaMetadataParser : public content::UtilityProcessHostClient {

};

// Private because content::UtilityProcessHostClient is ref-counted.

- virtual ~SafeMediaMetadataParser();

+ ~SafeMediaMetadataParser() override;

// Launches the utility process. Must run on the IO thread.

void StartWorkOnIOThread(const DoneCallback& callback);

@@ -77,8 +77,8 @@ class SafeMediaMetadataParser : public content::UtilityProcessHostClient {

// UtilityProcessHostClient implementation.

// Runs on the IO thread.

- virtual void OnProcessCrashed(int exit_code) override;

- virtual bool OnMessageReceived(const IPC::Message& message) override;

+ void OnProcessCrashed(int exit_code) override;

+ bool OnMessageReceived(const IPC::Message& message) override;

// All member variables are only accessed on the IO thread.

Profile* const profile_;