chrome/browser/media_galleries/fileapi/safe_audio_video_checker.h - Issue 660343006: Standardize usage of virtual/override/final in chrome/browser/media_galleries

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media_galleries/fileapi/safe_audio_video_checker.h

Issue 660343006: Standardize usage of virtual/override/final in chrome/browser/media_galleries (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/media_galleries/fileapi/readahead_file_stream_reader.h ('k') | chrome/browser/media_galleries/fileapi/safe_iapps_library_parser.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media_galleries/fileapi/safe_audio_video_checker.h

diff --git a/chrome/browser/media_galleries/fileapi/safe_audio_video_checker.h b/chrome/browser/media_galleries/fileapi/safe_audio_video_checker.h

index b548349b127b8718a2202a94d2dd5cd7c1aac107..9a1fac17e39c97322f29f69ab7b9bd513355ed0c 100644

--- a/chrome/browser/media_galleries/fileapi/safe_audio_video_checker.h

+++ b/chrome/browser/media_galleries/fileapi/safe_audio_video_checker.h

@@ -39,7 +39,7 @@ class SafeAudioVideoChecker : public content::UtilityProcessHostClient {

FINISHED_STATE

};

- virtual ~SafeAudioVideoChecker();

+ ~SafeAudioVideoChecker() override;

// Starts validation once the utility process has been started.

virtual void OnProcessStarted();

@@ -48,8 +48,8 @@ class SafeAudioVideoChecker : public content::UtilityProcessHostClient {

void OnCheckingFinished(bool valid);

// UtilityProcessHostClient implementation.

- virtual void OnProcessCrashed(int exit_code) override;

- virtual bool OnMessageReceived(const IPC::Message& message) override;

+ void OnProcessCrashed(int exit_code) override;

+ bool OnMessageReceived(const IPC::Message& message) override;

State state_;