Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2068)

Unified Diff: chrome/browser/media_galleries/fileapi/media_file_system_backend.h

Issue 660343006: Standardize usage of virtual/override/final in chrome/browser/media_galleries (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media_galleries/fileapi/media_file_system_backend.h
diff --git a/chrome/browser/media_galleries/fileapi/media_file_system_backend.h b/chrome/browser/media_galleries/fileapi/media_file_system_backend.h
index aa164d041579cb0dae0c8312bc546e79fca924fb..061c127221cc33a7bafbd743ff1dc2ac5c301d1a 100644
--- a/chrome/browser/media_galleries/fileapi/media_file_system_backend.h
+++ b/chrome/browser/media_galleries/fileapi/media_file_system_backend.h
@@ -37,7 +37,7 @@ class MediaFileSystemBackend : public storage::FileSystemBackend {
MediaFileSystemBackend(
const base::FilePath& profile_path,
base::SequencedTaskRunner* media_task_runner);
- virtual ~MediaFileSystemBackend();
+ ~MediaFileSystemBackend() override;
static bool CurrentlyOnMediaTaskRunnerThread();
static scoped_refptr<base::SequencedTaskRunner> MediaTaskRunner();
@@ -55,42 +55,41 @@ class MediaFileSystemBackend : public storage::FileSystemBackend {
const base::Callback<void(base::File::Error result)>& callback);
// FileSystemBackend implementation.
- virtual bool CanHandleType(storage::FileSystemType type) const override;
- virtual void Initialize(storage::FileSystemContext* context) override;
- virtual void ResolveURL(const storage::FileSystemURL& url,
- storage::OpenFileSystemMode mode,
- const OpenFileSystemCallback& callback) override;
- virtual storage::AsyncFileUtil* GetAsyncFileUtil(
+ bool CanHandleType(storage::FileSystemType type) const override;
+ void Initialize(storage::FileSystemContext* context) override;
+ void ResolveURL(const storage::FileSystemURL& url,
+ storage::OpenFileSystemMode mode,
+ const OpenFileSystemCallback& callback) override;
+ storage::AsyncFileUtil* GetAsyncFileUtil(
storage::FileSystemType type) override;
- virtual storage::WatcherManager* GetWatcherManager(
+ storage::WatcherManager* GetWatcherManager(
storage::FileSystemType type) override;
- virtual storage::CopyOrMoveFileValidatorFactory*
- GetCopyOrMoveFileValidatorFactory(storage::FileSystemType type,
- base::File::Error* error_code) override;
- virtual storage::FileSystemOperation* CreateFileSystemOperation(
+ storage::CopyOrMoveFileValidatorFactory* GetCopyOrMoveFileValidatorFactory(
+ storage::FileSystemType type,
+ base::File::Error* error_code) override;
+ storage::FileSystemOperation* CreateFileSystemOperation(
const storage::FileSystemURL& url,
storage::FileSystemContext* context,
base::File::Error* error_code) const override;
- virtual bool SupportsStreaming(
- const storage::FileSystemURL& url) const override;
- virtual bool HasInplaceCopyImplementation(
+ bool SupportsStreaming(const storage::FileSystemURL& url) const override;
+ bool HasInplaceCopyImplementation(
storage::FileSystemType type) const override;
- virtual scoped_ptr<storage::FileStreamReader> CreateFileStreamReader(
+ scoped_ptr<storage::FileStreamReader> CreateFileStreamReader(
const storage::FileSystemURL& url,
int64 offset,
int64 max_bytes_to_read,
const base::Time& expected_modification_time,
storage::FileSystemContext* context) const override;
- virtual scoped_ptr<storage::FileStreamWriter> CreateFileStreamWriter(
+ scoped_ptr<storage::FileStreamWriter> CreateFileStreamWriter(
const storage::FileSystemURL& url,
int64 offset,
storage::FileSystemContext* context) const override;
- virtual storage::FileSystemQuotaUtil* GetQuotaUtil() override;
- virtual const storage::UpdateObserverList* GetUpdateObservers(
+ storage::FileSystemQuotaUtil* GetQuotaUtil() override;
+ const storage::UpdateObserverList* GetUpdateObservers(
storage::FileSystemType type) const override;
- virtual const storage::ChangeObserverList* GetChangeObservers(
+ const storage::ChangeObserverList* GetChangeObservers(
storage::FileSystemType type) const override;
- virtual const storage::AccessObserverList* GetAccessObservers(
+ const storage::AccessObserverList* GetAccessObservers(
storage::FileSystemType type) const override;
private:

Powered by Google App Engine
This is Rietveld 408576698