chrome/browser/media_galleries/fileapi/itunes_data_provider.h - Issue 660343006: Standardize usage of virtual/override/final in chrome/browser/media_galleries

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media_galleries/fileapi/itunes_data_provider.h

Issue 660343006: Standardize usage of virtual/override/final in chrome/browser/media_galleries (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/media_galleries/fileapi/iphoto_file_util_unittest.cc ('k') | chrome/browser/media_galleries/fileapi/itunes_data_provider_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media_galleries/fileapi/itunes_data_provider.h

diff --git a/chrome/browser/media_galleries/fileapi/itunes_data_provider.h b/chrome/browser/media_galleries/fileapi/itunes_data_provider.h

index 893d9a601eb5771393ef66bf9b90132c10f0db13..788d47854096d2c8dc6d1420f3b7cf2590621524 100644

--- a/chrome/browser/media_galleries/fileapi/itunes_data_provider.h

+++ b/chrome/browser/media_galleries/fileapi/itunes_data_provider.h

@@ -32,7 +32,7 @@ class ITunesDataProvider : public iapps::IAppsDataProvider {

typedef std::map<TrackName, base::FilePath> Album;

explicit ITunesDataProvider(const base::FilePath& library_path);

- virtual ~ITunesDataProvider();

+ ~ITunesDataProvider() override;

// Get the platform path for the auto-add directory.

virtual const base::FilePath& auto_add_path() const;

@@ -65,8 +65,8 @@ class ITunesDataProvider : public iapps::IAppsDataProvider {

typedef std::map<ArtistName, Artist> Library;

// Parse the library xml file.

- virtual void DoParseLibrary(const base::FilePath& library_path,

- const ReadyCallback& ready_callback) override;

+ void DoParseLibrary(const base::FilePath& library_path,

+ const ReadyCallback& ready_callback) override;

// Called when the utility process finishes parsing the library XML file.

void OnLibraryParsed(const ReadyCallback& ready_callback,