Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1630)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/media_galleries/fileapi/device_media_async_file_util.h

Issue 660343006: Standardize usage of virtual/override/final in chrome/browser/media_galleries (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/media_galleries/fileapi/av_scanning_file_validator.h ('k') | chrome/browser/media_galleries/fileapi/iphoto_data_provider.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/media_galleries/fileapi/device_media_async_file_util.h
diff --git a/chrome/browser/media_galleries/fileapi/device_media_async_file_util.h b/chrome/browser/media_galleries/fileapi/device_media_async_file_util.h
index 270b056f869d70119ed2d947e289784c035510f3..ebfd6b83d0a6ebc26566ccfb220bc04b773eb1a6 100644
--- a/chrome/browser/media_galleries/fileapi/device_media_async_file_util.h
+++ b/chrome/browser/media_galleries/fileapi/device_media_async_file_util.h
@@ -29,7 +29,7 @@ enum MediaFileValidationType {
class DeviceMediaAsyncFileUtil : public storage::AsyncFileUtil {
public:
- virtual ~DeviceMediaAsyncFileUtil();
+ ~DeviceMediaAsyncFileUtil() override;
// Returns an instance of DeviceMediaAsyncFileUtil.
static scoped_ptr<DeviceMediaAsyncFileUtil> Create(
@@ -39,69 +39,60 @@ class DeviceMediaAsyncFileUtil : public storage::AsyncFileUtil {
bool SupportsStreaming(const storage::FileSystemURL& url);
// AsyncFileUtil overrides.
- virtual void CreateOrOpen(
- scoped_ptr<storage::FileSystemOperationContext> context,
- const storage::FileSystemURL& url,
- int file_flags,
- const CreateOrOpenCallback& callback) override;
- virtual void EnsureFileExists(
- scoped_ptr<storage::FileSystemOperationContext> context,
- const storage::FileSystemURL& url,
- const EnsureFileExistsCallback& callback) override;
- virtual void CreateDirectory(
- scoped_ptr<storage::FileSystemOperationContext> context,
- const storage::FileSystemURL& url,
- bool exclusive,
- bool recursive,
- const StatusCallback& callback) override;
- virtual void GetFileInfo(
- scoped_ptr<storage::FileSystemOperationContext> context,
- const storage::FileSystemURL& url,
- const GetFileInfoCallback& callback) override;
- virtual void ReadDirectory(
- scoped_ptr<storage::FileSystemOperationContext> context,
- const storage::FileSystemURL& url,
- const ReadDirectoryCallback& callback) override;
- virtual void Touch(scoped_ptr<storage::FileSystemOperationContext> context,
+ void CreateOrOpen(scoped_ptr<storage::FileSystemOperationContext> context,
+ const storage::FileSystemURL& url,
+ int file_flags,
+ const CreateOrOpenCallback& callback) override;
+ void EnsureFileExists(scoped_ptr<storage::FileSystemOperationContext> context,
+ const storage::FileSystemURL& url,
+ const EnsureFileExistsCallback& callback) override;
+ void CreateDirectory(scoped_ptr<storage::FileSystemOperationContext> context,
+ const storage::FileSystemURL& url,
+ bool exclusive,
+ bool recursive,
+ const StatusCallback& callback) override;
+ void GetFileInfo(scoped_ptr<storage::FileSystemOperationContext> context,
+ const storage::FileSystemURL& url,
+ const GetFileInfoCallback& callback) override;
+ void ReadDirectory(scoped_ptr<storage::FileSystemOperationContext> context,
const storage::FileSystemURL& url,
- const base::Time& last_access_time,
- const base::Time& last_modified_time,
+ const ReadDirectoryCallback& callback) override;
+ void Touch(scoped_ptr<storage::FileSystemOperationContext> context,
+ const storage::FileSystemURL& url,
+ const base::Time& last_access_time,
+ const base::Time& last_modified_time,
+ const StatusCallback& callback) override;
+ void Truncate(scoped_ptr<storage::FileSystemOperationContext> context,
+ const storage::FileSystemURL& url,
+ int64 length,
+ const StatusCallback& callback) override;
+ void CopyFileLocal(scoped_ptr<storage::FileSystemOperationContext> context,
+ const storage::FileSystemURL& src_url,
+ const storage::FileSystemURL& dest_url,
+ CopyOrMoveOption option,
+ const CopyFileProgressCallback& progress_callback,
const StatusCallback& callback) override;
- virtual void Truncate(scoped_ptr<storage::FileSystemOperationContext> context,
- const storage::FileSystemURL& url,
- int64 length,
- const StatusCallback& callback) override;
- virtual void CopyFileLocal(
- scoped_ptr<storage::FileSystemOperationContext> context,
- const storage::FileSystemURL& src_url,
- const storage::FileSystemURL& dest_url,
- CopyOrMoveOption option,
- const CopyFileProgressCallback& progress_callback,
- const StatusCallback& callback) override;
- virtual void MoveFileLocal(
- scoped_ptr<storage::FileSystemOperationContext> context,
- const storage::FileSystemURL& src_url,
- const storage::FileSystemURL& dest_url,
- CopyOrMoveOption option,
- const StatusCallback& callback) override;
- virtual void CopyInForeignFile(
+ void MoveFileLocal(scoped_ptr<storage::FileSystemOperationContext> context,
+ const storage::FileSystemURL& src_url,
+ const storage::FileSystemURL& dest_url,
+ CopyOrMoveOption option,
+ const StatusCallback& callback) override;
+ void CopyInForeignFile(
scoped_ptr<storage::FileSystemOperationContext> context,
const base::FilePath& src_file_path,
const storage::FileSystemURL& dest_url,
const StatusCallback& callback) override;
- virtual void DeleteFile(
- scoped_ptr<storage::FileSystemOperationContext> context,
- const storage::FileSystemURL& url,
- const StatusCallback& callback) override;
- virtual void DeleteDirectory(
- scoped_ptr<storage::FileSystemOperationContext> context,
- const storage::FileSystemURL& url,
- const StatusCallback& callback) override;
- virtual void DeleteRecursively(
+ void DeleteFile(scoped_ptr<storage::FileSystemOperationContext> context,
+ const storage::FileSystemURL& url,
+ const StatusCallback& callback) override;
+ void DeleteDirectory(scoped_ptr<storage::FileSystemOperationContext> context,
+ const storage::FileSystemURL& url,
+ const StatusCallback& callback) override;
+ void DeleteRecursively(
scoped_ptr<storage::FileSystemOperationContext> context,
const storage::FileSystemURL& url,
const StatusCallback& callback) override;
- virtual void CreateSnapshotFile(
+ void CreateSnapshotFile(
scoped_ptr<storage::FileSystemOperationContext> context,
const storage::FileSystemURL& url,
const CreateSnapshotFileCallback& callback) override;
« no previous file with comments | « chrome/browser/media_galleries/fileapi/av_scanning_file_validator.h ('k') | chrome/browser/media_galleries/fileapi/iphoto_data_provider.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698