Fixed the insertion handle showing issue on readonly element.

Fixed the insertion handle showing issue on readonly element.

Insertion handle is showing when we long press on readonly input
elements, which is not correct. This change takes care of correcting
it by counter measuring inside isEditableNode() API.

BUG=

Committed: https://crrev.com/e77498c3ec23d38f9075557f3af93d6f18afa3b1
Cr-Commit-Position: refs/heads/master@{#300636}

[AKVT, 2014-10-17 21:29:02]

ajith.v@samsung.com changed reviewers:
+ aurimas@chromium.org, jamesr@chromium.org

[AKVT, 2014-10-17 21:29:03]

@aurimas & jamesr PTAL

[aurimas (slooooooooow), 2014-10-17 21:56:21]

aurimas@chromium.org changed reviewers:
+ jdduke@chromium.org

[aurimas (slooooooooow), 2014-10-17 21:56:22]

+jdduke@chromium.org who has been working on insertion handles.

https://codereview.chromium.org/660343003/diff/1/content/public/android/java/...
File
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
(right):

https://codereview.chromium.org/660343003/diff/1/content/public/android/java/...
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:1916:
public boolean hasInsertion() {
The test is in the same package so you can change this to package protected.

[AKVT, 2014-10-18 15:36:51]

@aurimas, jamesr & jdduke PTAL

[AKVT, 2014-10-21 14:40:49]

@jdduke, jamesr & aurimas PTAL

[jdduke (slow), 2014-10-21 15:21:02]

content/public/android lgtm assuming the changes in content/renderer are
approved. Is there no associated bug here? I vaguely recall a similar issue
being reported by Samsung recently.

https://codereview.chromium.org/660343003/diff/20001/content/public/android/j...
File
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
(right):

https://codereview.chromium.org/660343003/diff/20001/content/public/android/j...
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:1916:
/* package */ protected boolean hasInsertion() {
Nit: No need for the /* package */ comment, that's not really a convention here.

[AKVT, 2014-10-21 16:01:41]

@jdduke Thanks.
@jamesr PTAL /render_view_impl.cc changes

https://codereview.chromium.org/660343003/diff/20001/content/public/android/j...
File
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
(right):

https://codereview.chromium.org/660343003/diff/20001/content/public/android/j...
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:1916:
/* package */ protected boolean hasInsertion() {
On 2014/10/21 15:21:01, jdduke wrote:
> Nit: No need for the /* package */ comment, that's not really a convention
here.

Done. Thanks

[jamesr, 2014-10-22 00:15:34]

lgtm

[AKVT, 2014-10-22 04:17:37]

The CQ bit was checked by ajith.v@samsung.com

[commit-bot: I haz the power, 2014-10-22 04:18:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/660343003/40001

[commit-bot: I haz the power, 2014-10-22 05:32:40]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-10-22 05:33:21]

Patchset 3 (id:??) landed as
https://crrev.com/e77498c3ec23d38f9075557f3af93d6f18afa3b1
Cr-Commit-Position: refs/heads/master@{#300636}