Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 660333003: Add support for app_shell-only extension APIs (Closed)

Created:
6 years, 2 months ago by James Cook
Modified:
6 years, 2 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add support for app_shell-only extension APIs Also add a stub for an identity-related API as an example. BUG=424651 TEST=app_shell_unittests Committed: https://crrev.com/62117928b7e16e4b1080e802f26ca43f8ce1e997 Cr-Commit-Position: refs/heads/master@{#300265}

Patch Set 1 #

Patch Set 2 : (shell-identity) be the dot in .com #

Patch Set 3 : (shell-identity) rebase #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+215 lines, -25 lines) Patch
M extensions/BUILD.gn View 1 2 5 chunks +7 lines, -2 lines 1 comment Download
M extensions/extensions.gyp View 1 2 5 chunks +7 lines, -3 lines 0 comments Download
A + extensions/shell/BUILD.gn View 1 chunk +3 lines, -4 lines 0 comments Download
M extensions/shell/DEPS View 1 chunk +2 lines, -1 line 0 comments Download
M extensions/shell/app_shell.gyp View 3 chunks +5 lines, -0 lines 0 comments Download
A extensions/shell/app_shell_resources.grd View 1 chunk +15 lines, -0 lines 0 comments Download
A + extensions/shell/app_shell_resources.gyp View 1 chunk +6 lines, -5 lines 0 comments Download
A extensions/shell/browser/api/api_registration.gyp View 1 chunk +22 lines, -0 lines 0 comments Download
A extensions/shell/browser/api/shell_identity/shell_identity_api.h View 1 1 chunk +32 lines, -0 lines 0 comments Download
A extensions/shell/browser/api/shell_identity/shell_identity_api.cc View 1 chunk +23 lines, -0 lines 0 comments Download
A extensions/shell/browser/api/shell_identity/shell_identity_api_unittest.cc View 1 2 1 chunk +25 lines, -0 lines 0 comments Download
M extensions/shell/browser/shell_extensions_browser_client.cc View 2 chunks +4 lines, -0 lines 0 comments Download
A extensions/shell/common/api/_api_features.json View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
A + extensions/shell/common/api/api.gyp View 2 chunks +2 lines, -9 lines 0 comments Download
A extensions/shell/common/api/schemas.gypi View 1 chunk +20 lines, -0 lines 0 comments Download
A extensions/shell/common/api/shell_identity.idl View 1 1 chunk +14 lines, -0 lines 0 comments Download
M extensions/shell/common/shell_extensions_client.cc View 3 chunks +10 lines, -1 line 0 comments Download
M tools/gritsettings/resource_ids View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
James Cook
Ken, PTAL This is partially a manual revert of https://codereview.chromium.org/571643003/ https://codereview.chromium.org/660333003/diff/40001/extensions/BUILD.gn File extensions/BUILD.gn (right): https://codereview.chromium.org/660333003/diff/40001/extensions/BUILD.gn#newcode69 ...
6 years, 2 months ago (2014-10-17 22:28:49 UTC) #2
Ken Rockot(use gerrit already)
lgtm
6 years, 2 months ago (2014-10-18 00:14:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/660333003/40001
6 years, 2 months ago (2014-10-20 14:16:24 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 2 months ago (2014-10-20 14:35:25 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 14:36:04 UTC) #7
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/62117928b7e16e4b1080e802f26ca43f8ce1e997
Cr-Commit-Position: refs/heads/master@{#300265}

Powered by Google App Engine
This is Rietveld 408576698