[Android] Add workaround to unbind gpu memory buffer only on NVIDIA

ui/gl/gl_image.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_GL_GL_IMAGE_H_
 #define UI_GL_GL_IMAGE_H_
 
 #include "base/memory/ref_counted.h"
 #include "ui/gfx/gpu_memory_buffer.h"
 #include "ui/gfx/native_widget_types.h"
@@ skipping 19 matching lines @@
   // Bind image to texture currently bound to GL_TEXTURE_2D target.
   virtual bool BindTexImage();
 
   // Release image from texture currently bound to GL_TEXTURE_2D target.
   virtual void ReleaseTexImage();
 
   // Called before the texture is used for drawing.
   virtual void WillUseTexImage();
 
   // Called after the texture has been used for drawing.
-  virtual void DidUseTexImage();
+  // If |release_tex_image| is false, then skip releasing image from texture
+  // currently bound to GL_TEXTURE_2D.
+  virtual void DidUseTexImage(bool release_tex_image);

[reveman, 2013/11/12 16:39:42]

Bind/release as part of Will/DidUseTexImage is an implementation detail. This
API should not expose that.

How about we add a "virtual void SetUnbindImageOnDidUse()" to the GLImage class
with a comment that makes it clear that this is for an Android work-around?
Consistent with GLContext::SetUnbindFboOnMakeCurrent.

[boliu, 2013/11/12 16:47:47]

Ahh, that's why this felt so weird. Yes, SetUnbindImageOnDidUse sounds more
reaonsable.

One more question, do you care what the default for workaround should be for
non-android platforms?

 
   // Create a GL image for a window.
   static scoped_refptr<GLImage> CreateGLImage(gfx::PluginWindowHandle window);
 
   // Create a GL image for a GPU Memory buffer.
   static scoped_refptr<GLImage> CreateGLImageForGpuMemoryBuffer(
       gfx::GpuMemoryBufferHandle buffer,
       gfx::Size size,
       unsigned internalformat);
 
  protected:
   virtual ~GLImage();
 
  private:
   friend class base::RefCounted<GLImage>;
 
   DISALLOW_COPY_AND_ASSIGN(GLImage);
 };
 
 }  // namespace gfx
 
 #endif  // UI_GL_GL_IMAGE_H_