Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 660293002: Refactor extension code for notification permission handling. (Closed)

Created:
6 years, 2 months ago by Miguel Garcia
Modified:
6 years, 2 months ago
CC:
chromium-reviews, peter+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git/+/master
Project:
chromium
Visibility:
Public.

Description

Refactor extension code for notification permission handling. As a first step just move it from chrome_content_browser client to the desktop_notification_service. BUG=392187 Committed: https://crrev.com/48ab3a669a1d03fd860fea34a023f8fa519a779c Cr-Commit-Position: refs/heads/master@{#300241}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -33 lines) Patch
M chrome/browser/chrome_content_browser_client.cc View 2 chunks +0 lines, -30 lines 0 comments Download
M chrome/browser/notifications/desktop_notification_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/notifications/desktop_notification_service.cc View 1 3 chunks +34 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Miguel Garcia
Context, I want to add notification support to https://chromiumcodereview.appspot.com/622793002/ and remove the RequestNotificationPermission method in ...
6 years, 2 months ago (2014-10-17 15:20:48 UTC) #2
Peter Beverloo
lgtm. Please run try-bots. https://chromiumcodereview.appspot.com/660293002/diff/1/chrome/browser/notifications/desktop_notification_service.cc File chrome/browser/notifications/desktop_notification_service.cc (right): https://chromiumcodereview.appspot.com/660293002/diff/1/chrome/browser/notifications/desktop_notification_service.cc#newcode177 chrome/browser/notifications/desktop_notification_service.cc:177: nit: double white line
6 years, 2 months ago (2014-10-17 15:29:31 UTC) #3
Miguel Garcia
Adding mukai@chromium.org for Owners review
6 years, 2 months ago (2014-10-17 16:02:49 UTC) #5
Miguel Garcia
https://codereview.chromium.org/660293002/diff/1/chrome/browser/notifications/desktop_notification_service.cc File chrome/browser/notifications/desktop_notification_service.cc (right): https://codereview.chromium.org/660293002/diff/1/chrome/browser/notifications/desktop_notification_service.cc#newcode177 chrome/browser/notifications/desktop_notification_service.cc:177: On 2014/10/17 15:29:31, Peter Beverloo wrote: > nit: double ...
6 years, 2 months ago (2014-10-17 16:21:41 UTC) #6
Jun Mukai
lgtm
6 years, 2 months ago (2014-10-17 20:17:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/660293002/20001
6 years, 2 months ago (2014-10-20 07:42:32 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-20 09:38:20 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 09:39:03 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/48ab3a669a1d03fd860fea34a023f8fa519a779c
Cr-Commit-Position: refs/heads/master@{#300241}

Powered by Google App Engine
This is Rietveld 408576698