Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 660253004: [ServiceWorker] Add unittests for ServiceWorkerWriteToCacheJob. (Closed)

Created:
6 years, 2 months ago by horo
Modified:
6 years, 2 months ago
Reviewers:
michaeln
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[ServiceWorker] Add unittests for ServiceWorkerWriteToCacheJob. BUG=425396, 414026 Committed: https://crrev.com/2a744d445b7dde718c85f392bc24c3ddc7e7f987 Cr-Commit-Position: refs/heads/master@{#300867}

Patch Set 1 : #

Total comments: 10

Patch Set 2 : incorporated michaeln's comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+303 lines, -0 lines) Patch
M content/browser/service_worker/service_worker_provider_host.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_storage.h View 1 chunk +1 line, -0 lines 0 comments Download
A content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc View 1 1 chunk +300 lines, -0 lines 0 comments Download
M content/content_tests.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
horo
michaeln@ Could you please review this?
6 years, 2 months ago (2014-10-22 13:41:52 UTC) #3
michaeln
lgtm https://codereview.chromium.org/660253004/diff/20001/content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc File content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc (right): https://codereview.chromium.org/660253004/diff/20001/content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc#newcode146 content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc:146: virtual ~MockHttpProtocolHandler() {} per the c++ 11 guidance ...
6 years, 2 months ago (2014-10-22 22:39:06 UTC) #4
horo
Thank you! https://codereview.chromium.org/660253004/diff/20001/content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc File content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc (right): https://codereview.chromium.org/660253004/diff/20001/content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc#newcode146 content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc:146: virtual ~MockHttpProtocolHandler() {} On 2014/10/22 22:39:06, michaeln ...
6 years, 2 months ago (2014-10-23 04:46:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/660253004/60001
6 years, 2 months ago (2014-10-23 10:29:47 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:60001)
6 years, 2 months ago (2014-10-23 11:15:49 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-23 11:17:35 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2a744d445b7dde718c85f392bc24c3ddc7e7f987
Cr-Commit-Position: refs/heads/master@{#300867}

Powered by Google App Engine
This is Rietveld 408576698