Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(657)

Unified Diff: Source/core/dom/ScriptLoader.h

Issue 660233002: Oilpan: move ScriptLoader to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: ALLOW_UNUSED => ALLOW_UNUSED_LOCAL Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/dom/ScriptLoader.h
diff --git a/Source/core/dom/ScriptLoader.h b/Source/core/dom/ScriptLoader.h
index d657e8316354301cbf3f07a7931d83d635b2c64b..323b5c51451d43c75a577f72c4f225fdeb82745e 100644
--- a/Source/core/dom/ScriptLoader.h
+++ b/Source/core/dom/ScriptLoader.h
@@ -36,10 +36,15 @@ class ScriptLoaderClient;
class ScriptSourceCode;
-class ScriptLoader final : private ScriptResourceClient {
+class ScriptLoader final : public NoBaseWillBeGarbageCollectedFinalized<ScriptLoader>, private ScriptResourceClient {
public:
- static PassOwnPtr<ScriptLoader> create(Element*, bool createdByParser, bool isEvaluated);
+ static PassOwnPtrWillBeRawPtr<ScriptLoader> create(Element* element, bool createdByParser, bool isEvaluated)
+ {
+ return adoptPtrWillBeNoop(new ScriptLoader(element, createdByParser, isEvaluated));
+ }
+
virtual ~ScriptLoader();
+ virtual void trace(Visitor*);
Element* element() const { return m_element; }
@@ -109,12 +114,6 @@ private:
ScriptLoader* toScriptLoaderIfPossible(Element*);
-inline PassOwnPtr<ScriptLoader> ScriptLoader::create(Element* element, bool createdByParser, bool isEvaluated)
-{
- return adoptPtr(new ScriptLoader(element, createdByParser, isEvaluated));
-}
-
-}
-
+} // namespace blink
-#endif
+#endif // ScriptLoader_h

Powered by Google App Engine
This is Rietveld 408576698