Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Side by Side Diff: Source/core/svg/SVGScriptElement.h

Issue 660233002: Oilpan: move ScriptLoader to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: No detachment of ScriptLoaders when finalizing ScriptRunner Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/html/HTMLScriptElement.cpp ('k') | Source/core/svg/SVGScriptElement.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2008 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2008 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2007 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2007 Rob Buis <buis@kde.org>
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 28 matching lines...) Expand all
39 DEFINE_WRAPPERTYPEINFO(); 39 DEFINE_WRAPPERTYPEINFO();
40 public: 40 public:
41 static PassRefPtrWillBeRawPtr<SVGScriptElement> create(Document&, bool wasIn sertedByParser); 41 static PassRefPtrWillBeRawPtr<SVGScriptElement> create(Document&, bool wasIn sertedByParser);
42 42
43 ScriptLoader* loader() const { return m_loader.get(); } 43 ScriptLoader* loader() const { return m_loader.get(); }
44 44
45 #if ENABLE(ASSERT) 45 #if ENABLE(ASSERT)
46 virtual bool isAnimatableAttribute(const QualifiedName&) const override; 46 virtual bool isAnimatableAttribute(const QualifiedName&) const override;
47 #endif 47 #endif
48 48
49 virtual void trace(Visitor*) override;
50
49 private: 51 private:
50 SVGScriptElement(Document&, bool wasInsertedByParser, bool alreadyStarted); 52 SVGScriptElement(Document&, bool wasInsertedByParser, bool alreadyStarted);
51 virtual ~SVGScriptElement(); 53 virtual ~SVGScriptElement();
52 54
53 virtual void parseAttribute(const QualifiedName&, const AtomicString&) overr ide; 55 virtual void parseAttribute(const QualifiedName&, const AtomicString&) overr ide;
54 virtual InsertionNotificationRequest insertedInto(ContainerNode*) override; 56 virtual InsertionNotificationRequest insertedInto(ContainerNode*) override;
55 virtual void didNotifySubtreeInsertionsToDocument() override; 57 virtual void didNotifySubtreeInsertionsToDocument() override;
56 virtual void childrenChanged(const ChildrenChange&) override; 58 virtual void childrenChanged(const ChildrenChange&) override;
57 virtual void didMoveToNewDocument(Document& oldDocument) override; 59 virtual void didMoveToNewDocument(Document& oldDocument) override;
58 60
(...skipping 14 matching lines...) Expand all
73 virtual bool deferAttributeValue() const override; 75 virtual bool deferAttributeValue() const override;
74 virtual bool hasSourceAttribute() const override; 76 virtual bool hasSourceAttribute() const override;
75 77
76 virtual void dispatchLoadEvent() override; 78 virtual void dispatchLoadEvent() override;
77 79
78 virtual PassRefPtrWillBeRawPtr<Element> cloneElementWithoutAttributesAndChil dren() override; 80 virtual PassRefPtrWillBeRawPtr<Element> cloneElementWithoutAttributesAndChil dren() override;
79 virtual bool rendererIsNeeded(const RenderStyle&) override { return false; } 81 virtual bool rendererIsNeeded(const RenderStyle&) override { return false; }
80 82
81 virtual Timer<SVGElement>* svgLoadEventTimer() override { return &m_svgLoadE ventTimer; } 83 virtual Timer<SVGElement>* svgLoadEventTimer() override { return &m_svgLoadE ventTimer; }
82 84
83
84 Timer<SVGElement> m_svgLoadEventTimer; 85 Timer<SVGElement> m_svgLoadEventTimer;
85 OwnPtr<ScriptLoader> m_loader; 86 OwnPtrWillBeMember<ScriptLoader> m_loader;
86 }; 87 };
87 88
88 } // namespace blink 89 } // namespace blink
89 90
90 #endif // SVGScriptElement_h 91 #endif // SVGScriptElement_h
OLDNEW
« no previous file with comments | « Source/core/html/HTMLScriptElement.cpp ('k') | Source/core/svg/SVGScriptElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698