Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 66023005: Move ScrollElasticityController to platform/mac/ (Closed)

Created:
7 years, 1 month ago by pilgrim_google
Modified:
7 years ago
CC:
blink-reviews, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), dstockwell, Timothy Loh, darktears, Steve Block, dino_apple.com, Eric Willigers, darin (slow to review), jamesr
Visibility:
Public.

Description

Move ScrollElasticityController to platform/mac/ BUG=297477

Patch Set 1 #

Patch Set 2 : import CoreFoundation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -537 lines) Patch
M Source/core/core.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/platform/mac/ScrollAnimatorMac.h View 1 chunk +1 line, -1 line 0 comments Download
D Source/core/platform/mac/ScrollElasticityController.h View 1 chunk +0 lines, -103 lines 0 comments Download
D Source/core/platform/mac/ScrollElasticityController.mm View 1 chunk +0 lines, -428 lines 0 comments Download
M Source/platform/blink_platform.gypi View 1 chunk +3 lines, -1 line 0 comments Download
A + Source/platform/mac/ScrollElasticityController.h View 1 2 chunks +4 lines, -1 line 0 comments Download
A + Source/platform/mac/ScrollElasticityController.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
pilgrim_google
7 years, 1 month ago (2013-11-11 15:51:01 UTC) #1
eseidel
lgtm Seems reasonable.
7 years, 1 month ago (2013-11-11 18:35:56 UTC) #2
pilgrim_google
On 2013/11/11 18:35:56, eseidel wrote: > lgtm > > Seems reasonable. This file compiled when ...
7 years, 1 month ago (2013-11-12 14:49:18 UTC) #3
pilgrim_google
Bump. Can someone help with this?
7 years ago (2013-12-09 14:51:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pilgrim@chromium.org/66023005/50001
7 years ago (2013-12-09 17:35:26 UTC) #5
abarth-chromium
On 2013/12/09 14:51:27, pilgrim_google wrote: > Bump. Can someone help with this? The try bot ...
7 years ago (2013-12-09 17:35:33 UTC) #6
commit-bot: I haz the power
7 years ago (2013-12-09 17:35:36 UTC) #7
Failed to apply patch for Source/platform/mac/ScrollElasticityController.h:
File exist but was about to be overwriten
Patch:   NR 
Source/core/platform/mac/ScrollElasticityController.h->Source/platform/mac/ScrollElasticityController.h
Index: Source/platform/mac/ScrollElasticityController.h
diff --git a/Source/core/platform/mac/ScrollElasticityController.h
b/Source/platform/mac/ScrollElasticityController.h
similarity index 96%
rename from Source/core/platform/mac/ScrollElasticityController.h
rename to Source/platform/mac/ScrollElasticityController.h
index
180e79c9335c9e0cd8c93f143b85de2e5f774eb4..d1caab9621b790223e1b087b0f3a3fcf01f99fd2
100644
--- a/Source/core/platform/mac/ScrollElasticityController.h
+++ b/Source/platform/mac/ScrollElasticityController.h
@@ -28,6 +28,9 @@
 
 #if USE(RUBBER_BANDING)
 
+#import <CoreFoundation/CoreFoundation.h>
+
+#include "platform/PlatformExport.h"
 #include "platform/geometry/FloatPoint.h"
 #include "platform/geometry/FloatSize.h"
 #include "platform/scroll/ScrollTypes.h"
@@ -37,7 +40,7 @@ namespace WebCore {
 
 class PlatformWheelEvent;
 
-class ScrollElasticityControllerClient {
+class PLATFORM_EXPORT ScrollElasticityControllerClient {
 protected:
     virtual ~ScrollElasticityControllerClient() { }

Powered by Google App Engine
This is Rietveld 408576698