chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_unittest.mm - Issue 6602070: Port autocomplete_edit_view_browsertest.cc to Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_unittest.mm

Issue 6602070: Port autocomplete_edit_view_browsertest.cc to Mac. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix PrimarySelection test. Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor_unittest.mm ('k') | chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_unittest_helper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_unittest.mm

diff --git a/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_unittest.mm b/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_unittest.mm

index a86e8ce0e66cae03df7b8253167275f0049c8d7b..1aa65ec2be68f4b5d5b1f93fc6a30f14aa958ab6 100644

--- a/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_unittest.mm

+++ b/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_unittest.mm

@@ -331,6 +331,7 @@ TEST_F(AutocompleteTextFieldObserverTest, ResetFieldEditorContinuesEditing) {

// This should begin editing and indicate a change.

EXPECT_CALL(field_observer_, OnDidBeginEditing());

+ EXPECT_CALL(field_observer_, OnBeforeChange());

EXPECT_CALL(field_observer_, OnDidChange());

[editor shouldChangeTextInRange:NSMakeRange(0, 0) replacementString:@""];

[editor didChangeText];

@@ -749,11 +750,13 @@ TEST_F(AutocompleteTextFieldObserverTest, SendsEditingMessages) {

// This should begin editing and indicate a change.

EXPECT_CALL(field_observer_, OnDidBeginEditing());

+ EXPECT_CALL(field_observer_, OnBeforeChange());

EXPECT_CALL(field_observer_, OnDidChange());

[editor shouldChangeTextInRange:NSMakeRange(0, 0) replacementString:@""];

[editor didChangeText];

// Further changes don't send the begin message.

+ EXPECT_CALL(field_observer_, OnBeforeChange());

EXPECT_CALL(field_observer_, OnDidChange());

[editor shouldChangeTextInRange:NSMakeRange(0, 0) replacementString:@""];

[editor didChangeText];