web-ui settings: Standard font setting now correlates to WebKit's standard fo...

web-ui settings: Standard font setting now correlates to WebKit's standard font family only.

BUG=74434
TEST=Verify that changing the 'standard font' only applies to unspecified font styles.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=76463

[csilv, 2011-03-01 02:48:51]

+jhawkins, +tony for review.

(trybots are being a little temperamental, but I expect this to go green on all
of them.)

[James Hawkins, 2011-03-01 17:47:49]

LGTM

[tony, 2011-03-01 19:11:57]

The code change LG, but what do we do about users who set their font prior to
this change?  It seems like you can't change the value of
webkit.webprefs.sansserif_font_family or webkit.webprefs.serif_font_family and
maybe some users want to reset it?  I guess users can always just start a new
profile.

[csilv, 2011-03-01 19:51:01]

That's a valid question.  Right now manually editing the prefs file, or blowing
away the profile are the only solutions.  I'm sure that we want to retain the
underlying preference so that a user can manually set it, (or perhaps an
extension could set it), so I don't see a good opportunity to change the old
settings.

On 2011/03/01 19:11:57, tony wrote:
> The code change LG, but what do we do about users who set their font prior to
> this change?  It seems like you can't change the value of
> webkit.webprefs.sansserif_font_family or webkit.webprefs.serif_font_family and
> maybe some users want to reset it?  I guess users can always just start a new
> profile.

[tony, 2011-03-01 20:04:50]

I'm not sure how many people would have set this since it's not on stable yet,
so maybe my concerns are overblown.

One crappy idea is to have a "reset to defaults" button in the customize fonts
dialog.  I don't like having an extra button and not having it in other places
is weird.  On the other hand, getting your font settings wrong can really mess
up web pages.

This is why there used to be a (stale and incomplete) "reset all prefs" button
in the native UI.  It gave users a chance to undo bad settings.

On 2011/03/01 19:51:01, csilv wrote:
> That's a valid question.  Right now manually editing the prefs file, or
blowing
> away the profile are the only solutions.  I'm sure that we want to retain the
> underlying preference so that a user can manually set it, (or perhaps an
> extension could set it), so I don't see a good opportunity to change the old
> settings.
> 
> On 2011/03/01 19:11:57, tony wrote:
> > The code change LG, but what do we do about users who set their font prior
to
> > this change?  It seems like you can't change the value of
> > webkit.webprefs.sansserif_font_family or webkit.webprefs.serif_font_family
and
> > maybe some users want to reset it?  I guess users can always just start a
new
> > profile.

[arv (Not doing code reviews), 2011-03-01 20:16:48]

I actually wanted a way to "reset" this in the past. How about adding
a "Default" to the select "Font size" select box?

erik








On Tue, Mar 1, 2011 at 12:04,  <tony@chromium.org> wrote:
> I'm not sure how many people would have set this since it's not on stable
> yet,
> so maybe my concerns are overblown.
>
> One crappy idea is to have a "reset to defaults" button in the customize
> fonts
> dialog.  I don't like having an extra button and not having it in other
> places
> is weird.  On the other hand, getting your font settings wrong can really
> mess
> up web pages.
>
> This is why there used to be a (stale and incomplete) "reset all prefs"
> button
> in the native UI.  It gave users a chance to undo bad settings.
>
> On 2011/03/01 19:51:01, csilv wrote:
>>
>> That's a valid question.  Right now manually editing the prefs file, or
>
> blowing
>>
>> away the profile are the only solutions.  I'm sure that we want to retain
>> the
>> underlying preference so that a user can manually set it, (or perhaps an
>> extension could set it), so I don't see a good opportunity to change the
>> old
>> settings.
>
>> On 2011/03/01 19:11:57, tony wrote:
>> > The code change LG, but what do we do about users who set their font
>> > prior
>
> to
>>
>> > this change?  It seems like you can't change the value of
>> > webkit.webprefs.sansserif_font_family or
>> > webkit.webprefs.serif_font_family
>
> and
>>
>> > maybe some users want to reset it?  I guess users can always just start
>> > a
>
> new
>>
>> > profile.
>
>
>
> http://codereview.chromium.org/6602021/
>

[csilv, 2011-03-01 20:31:15]

Erik,

You said add default to 'font size', but i assume you meant the font selection. 
(The font size control is a range.)  We could do this, but it doesn't address
Tony's issue that there's no way to reset the old serif & sans-serif settings a
user may have already set.

Tony, we did have the 'Reset to Defaults' button in dom-ui settings for a short
period but the UI leads decided to remove it.

I think a Reset to Defaults button in the fonts panel itself might be worth
doing.  That could also reset the old serif & sans-serif settings to address
Tony's issue.

[csilv, 2011-03-01 20:31:32]

cc: ainslie

[csilv, 2011-03-01 23:35:04]

Folks, trybots are now green so I'm going to commit this CL.  If we want to add
a reset button, we should handle that in a separate CL.