Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2942)

Unified Diff: chrome/browser/metrics/thread_watcher.h

Issue 6602004: Trying changes to see the perfomance impact on Mac.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/browser_process_impl.cc ('k') | chrome/browser/metrics/thread_watcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/metrics/thread_watcher.h
===================================================================
--- chrome/browser/metrics/thread_watcher.h (revision 76170)
+++ chrome/browser/metrics/thread_watcher.h (working copy)
@@ -8,14 +8,13 @@
#define CHROME_BROWSER_METRICS_THREAD_WATCHER_H_
#pragma once
-#if 0
-
#include <map>
#include <string>
#include <vector>
#include "base/basictypes.h"
#include "base/gtest_prod_util.h"
+#include "base/message_loop.h"
#include "base/metrics/histogram.h"
#include "base/ref_counted.h"
#include "base/scoped_ptr.h"
@@ -23,7 +22,6 @@
#include "base/task.h"
#include "base/threading/thread.h"
#include "base/time.h"
-#include "chrome/browser/browser_process_sub_thread.h"
#include "chrome/browser/browser_thread.h"
#include "chrome/common/notification_observer.h"
#include "chrome/common/notification_registrar.h"
@@ -107,21 +105,21 @@
// OnPongMessage. It also posts a task (OnCheckResponsiveness) to check
// responsiveness of monitored thread that would be called after waiting
// unresponsive_time_.
- // This method is accessible on WATCHDOG thread.
+ // This method is accessible on WatchDogThread.
virtual void PostPingMessage();
// This method handles a Pong Message from watched thread. It will track the
// response time (pong time minus ping time) via histograms. It posts a
// PostPingMessage task that would be called after waiting sleep_time_. It
// increments ping_sequence_number_ by 1.
- // This method is accessible on WATCHDOG thread.
+ // This method is accessible on WatchDogThread.
virtual void OnPongMessage(uint64 ping_sequence_number);
// This method will determine if the watched thread is responsive or not. If
// the latest ping_sequence_number_ is not same as the ping_sequence_number
// that is passed in, then we can assume that watched thread has responded
// with a pong message.
- // This method is accessible on WATCHDOG thread.
+ // This method is accessible on WatchDogThread.
virtual bool OnCheckResponsiveness(uint64 ping_sequence_number);
private:
@@ -203,28 +201,36 @@
// Register() stores a pointer to the given ThreadWatcher in a global map.
static void Register(ThreadWatcher* watcher);
- // This method posts a task on WATCHDOG thread to RevokeAll tasks and to
+ // This method posts a task on WatchDogThread to RevokeAll tasks and to
// deactive thread watching of other threads and tell NotificationService to
// stop calling Observe.
+ // This method is accessible on UI thread.
static void StopWatchingAll();
// RemoveAll NotificationTypes that are being observed.
+ // This method is accessible on UI thread.
static void RemoveNotifications();
private:
// Allow tests to access our innards for testing purposes.
FRIEND_TEST(ThreadWatcherTest, Registration);
+ // Delete all thread watcher objects and remove them from global map.
+ // This method is accessible on WatchDogThread.
+ void DeleteAll();
+
// This will ensure that the watching is actively taking place. It will wakeup
// all thread watchers every 2 seconds. This is the implementation of
// NotificationObserver. When a matching notification is posted to the
// notification service, this method is called.
+ // This method is accessible on UI thread.
virtual void Observe(NotificationType type,
const NotificationSource& source,
const NotificationDetails& details);
// This will ensure that the watching is actively taking place, and awaken
// all thread watchers that are registered.
+ // This method is accessible on WatchDogThread.
virtual void WakeUpAll();
// The Find() method can be used to test to see if a given ThreadWatcher was
@@ -250,23 +256,41 @@
};
//------------------------------------------------------------------------------
-// Class for WATCHDOG thread and in its Init method, we start watching UI, IO,
+// Class for WatchDogThread and in its Init method, we start watching UI, IO,
// DB, FILE, CACHED threads.
-class WatchDogThread : public BrowserProcessSubThread {
+class WatchDogThread : public base::Thread {
public:
+ // Constructor.
WatchDogThread();
+
+ // Destroys the thread and stops the thread.
virtual ~WatchDogThread();
+ // Start watching all browser threads.
+ static void StartWatchingAll();
+
+ // Returns current message loop for the watchdog thread. This only returns
+ // non-null after a successful call to Start. After Stop has been called,
+ // this will return NULL.
+ static MessageLoop* CurrentMessageLoop();
+
+ // Callable on any thread. Returns whether you're currently on a
+ // watchdog_thread_.
+ static bool CurrentlyOnWatchDogThread();
+
protected:
virtual void Init();
+ virtual void CleanUp();
+ virtual void CleanUpAfterMessageLoopDestruction();
+ // This lock protects watchdog_thread_.
+ static base::Lock lock_;
+ static WatchDogThread* watchdog_thread_;
+
DISALLOW_COPY_AND_ASSIGN(WatchDogThread);
};
-
DISABLE_RUNNABLE_METHOD_REFCOUNT(ThreadWatcher);
DISABLE_RUNNABLE_METHOD_REFCOUNT(ThreadWatcherList);
-#endif // 0
-
#endif // CHROME_BROWSER_METRICS_THREAD_WATCHER_H_
« no previous file with comments | « chrome/browser/browser_process_impl.cc ('k') | chrome/browser/metrics/thread_watcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698